libbeam icon indicating copy to clipboard operation
libbeam copied to clipboard

Update singularity check for KB camera model

Open nickcharron opened this issue 3 years ago • 0 comments

In this paper: https://arxiv.org/pdf/1807.08957.pdf

They describe that KB has a singularity at z = 0. In our InProjectionDomain function, we only check that z != 0

See check here:

https://github.com/BEAMRobotics/libbeam/blob/4384b414bd30b893b91a17ea29258a0816110d05/beam_calibration/src/KannalaBrandt.cpp#L143

Since it's a singularity, I think we should exclude points that are 'near' z = 0, not exact, as points approaching zero will probably give errors as well. Especially with machine rounding errors

@jakemclaughlin6 @adthoms (should be a quick fix if either of you have a minute)

nickcharron avatar Sep 19 '22 18:09 nickcharron