ball icon indicating copy to clipboard operation
ball copied to clipboard

[CMAKE] Refactored FindXDR.cmake module

Open philthiel opened this issue 8 years ago • 2 comments

Configuration problems on macOS using -std=c++11 concerning finding XDR should be resolved now. This should fix #639.

philthiel avatar Nov 23 '17 08:11 philthiel

The FindXDR module seems to work now! However, FindBoost stopped working with your PR on my Mac (Sierra, CMake 3.8, Contrib) for some reason.

Master:

-- Performing Test BALL_XDRREC_CREATE_VOID_VOID_INT - Success
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE  
-- Boost version: 1.60.0

PR:

-- Performing Test BALL_XDRREC_CREATE_VOID_VOID_INT - Success
-- Looking for pthread.h
-- Looking for pthread.h - not found
CMake Error at /Applications/CLion.app/Contents/bin/cmake/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
  /Applications/CLion.app/Contents/bin/cmake/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE)
  /Applications/CLion.app/Contents/bin/cmake/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  /Applications/CLion.app/Contents/bin/cmake/share/cmake-3.8/Modules/CMakeFindDependencyMacro.cmake:55 (find_package)
  /Applications/CLion.app/Contents/bin/cmake/share/cmake-3.8/Modules/FindBoost.cmake:1478 (find_dependency)
  cmake/BALLConfigBoost.cmake:38 (FIND_PACKAGE)
  CMakeLists.txt:133 (INCLUDE)

This problem does not seem to occur with our Sierra and El Capitan build workers, though.

tkemmer avatar Nov 23 '17 12:11 tkemmer

CI runs are ok: on macOS it is only the Timer_test that failed. Not related to XDR.

The boost thing is weird, I will look into that.

philthiel avatar Nov 23 '17 12:11 philthiel