microsoft-authentication-library-common-for-android Handle error gracefully when app url scheme is not found

Can we add an error handler to the AmazonAppUri processing? So that if someone does not have the app yet installed it is not crashing the authentication process? Then an hint can be displayed, that the app should be installed.

cc: @shahzaibj

Oct 03 '24 21:10 denniskniep

@microsoft-github-policy-service agree

Oct 03 '24 21:10 denniskniep

@denniskniep I'm not sure what a hint could be for installing the app. Is the app on PlayStore and/or is there a URL for downloading this app?

Oct 09 '24 21:10 shahzaibj

Then an hint can be displayed, that the app should be installed.

@shahzaibj What I meant with that was: Currently the authentication process crashes entirely, which means the actual website is not visible anymore to the user, therefore the authentication process can not render any guidance to the user to resolve that issue. A potential guidance from the authentication process could be a hint, that the user should install an app.

But that is nothing I see in that library here. It must be implemented by the individual authentication process. However, to enable this, it would be good to catch that error.

Oct 09 '24 21:10 denniskniep

@shahzaibj implemented your suggestions

Oct 10 '24 05:10 denniskniep

Hi @shahzaibj, can you propose someone who can be the second reviewer?

Oct 20 '24 10:10 denniskniep

@rpdome any further feedback? Can we merge this?

Nov 19 '24 11:11 denniskniep

@rpdome I kept up with recent changes in repo with rebase

Nov 20 '24 19:11 denniskniep

@denniskniep how did you test this? Can that be written as an automated test?

Nov 25 '24 16:11 iamgusain

how did you test this? Can that be written as an automated test?

@iamgusain I didn´t wrote a unit-test so far for this case. If you want me to write a test for that catch block, I can look into that.

Nov 25 '24 22:11 denniskniep

Hi, I merged dev into that pr to resolve conflicts

@iamgusain @shahzaibj There are now two approvals, can we merge this?

Dec 21 '24 14:12 denniskniep

@iamgusain @shahzaibj any news? Is there something I need to change? Can we merge it? (If yes I can rebase master, so that it is then mergable)

Feb 08 '25 09:02 denniskniep

@rpdome @iamgusain @shahzaibj how can we progress here?

Feb 27 '25 21:02 denniskniep

@rpdome @iamgusain @shahzaibj any updates?

Mar 22 '25 11:03 denniskniep

@p3dr0rv @rpdome @iamgusain @shahzaibj Any chance to get that merged? let me know, then I will rebase

Nov 05 '25 22:11 denniskniep