SCIMReferenceCode icon indicating copy to clipboard operation
SCIMReferenceCode copied to clipboard

Update to .NET 8

Open Sefriol opened this issue 1 year ago • 9 comments

  • [x] Update other dependancies
  • [x] Convert Postman Collection into Playwright API tests
  • [x] Squash commits
  • [ ] Remove Newtonsoft?

Sefriol avatar May 20 '24 16:05 Sefriol

Removal on Newtonsoft might be possible, but requires so much rewrite that it needs its own PR.

While Postman collection was okey for testing, it was rather slow to run and requires a license for those who are most likely candidates to use software like this. I created a Playwright tests that mimic the test cases of the postman collection and improve them a little bit.

I also removed a bunch of files which were not used, but some might be in some other context (like profile pictures and photos?). I am not sure if DataContract classes were auto-generated using some tool, but feel free to give guidance on how to make this PR work.

@boscoMW @marcusca10 Are you currently overseering this repo?

Sefriol avatar May 24 '24 16:05 Sefriol

you have a bug in
public static class RequestExtensions public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

ibe-SAG avatar Jun 16 '24 01:06 ibe-SAG

you have a bug in public static class RequestExtensions public static Uri GetBaseResourceIdentifier(this HttpContext context)

line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because

context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users

you can not build an Uri from incomplete string

Good catch. Fixed.

Sefriol avatar Jun 18 '24 10:06 Sefriol

Whats the status of this PR?

garrettlondon1 avatar Sep 05 '24 13:09 garrettlondon1

also interesting

SvatKalashmat avatar Oct 31 '24 00:10 SvatKalashmat

Repository probably needs a complete rewrite. It has a lot of files which are almost impossible to figure out what they are for.

And it seems like there is no current maintainers for this repository, so this PR will most likely go nowhere.

Sefriol avatar Oct 31 '24 10:10 Sefriol

@Sefriol , Can you please help to merge your updated version of this sample with .net v8.0 into AzureAD:master branch.

AmitavaHazra avatar Mar 17 '25 09:03 AmitavaHazra

I would need input from the repository maintainers, but there seems to be none.

Sefriol avatar Mar 17 '25 12:03 Sefriol

@Sefriol Yes, can I somehow get this updated repository link where you have complete updated versioning of this sample using .net8.0

AmitavaHazra avatar Mar 17 '25 12:03 AmitavaHazra