Update to .NET 8
- [x] Update other dependancies
- [x] Convert Postman Collection into Playwright API tests
- [x] Squash commits
- [ ] Remove Newtonsoft?
Removal on Newtonsoft might be possible, but requires so much rewrite that it needs its own PR.
While Postman collection was okey for testing, it was rather slow to run and requires a license for those who are most likely candidates to use software like this. I created a Playwright tests that mimic the test cases of the postman collection and improve them a little bit.
I also removed a bunch of files which were not used, but some might be in some other context (like profile pictures and photos?). I am not sure if DataContract classes were auto-generated using some tool, but feel free to give guidance on how to make this PR work.
@boscoMW @marcusca10 Are you currently overseering this repo?
you have a bug in
public static class RequestExtensions
public static Uri GetBaseResourceIdentifier(this HttpContext context)
line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because
context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users
you can not build an Uri from incomplete string
you have a bug in public static class RequestExtensions public static Uri GetBaseResourceIdentifier(this HttpContext context)
line string resourceIdentifier = new Uri(context.Request.Path.Value).AbsoluteUri; throw exception, because
context.Request.Path.Value = /scim/Users and not https://{host[:{port}/scim/Users
you can not build an Uri from incomplete string
Good catch. Fixed.
Whats the status of this PR?
also interesting
Repository probably needs a complete rewrite. It has a lot of files which are almost impossible to figure out what they are for.
And it seems like there is no current maintainers for this repository, so this PR will most likely go nowhere.
@Sefriol , Can you please help to merge your updated version of this sample with .net v8.0 into AzureAD:master branch.
I would need input from the repository maintainers, but there seems to be none.
@Sefriol Yes, can I somehow get this updated repository link where you have complete updated versioning of this sample using .net8.0