SCIMReferenceCode icon indicating copy to clipboard operation
SCIMReferenceCode copied to clipboard

PatchRoles: Incorrect enum used to check when comparing operation.Path.AttributePath

Open chholm opened this issue 5 years ago • 0 comments

When patching Roles, it looks like the wrong enum-type is beeing used for this check:

https://github.com/AzureAD/SCIMReferenceCode/blob/ae181c1d0800a2a22333f0a4081c4012f39028e8/Microsoft.SystemForCrossDomainIdentityManagement/Protocol/ProtocolExtensions.cs#L1105

 if
            (
                !string.Equals(
                    Microsoft.SCIM.AttributeNames.PhoneNumbers,
                    operation.Path.AttributePath,
                    StringComparison.OrdinalIgnoreCase)
            )
            {
                return roles;
            }

Shouldn't the correct enum-value be: Microsoft.SCIM.AttributeNames.Roles ?

chholm avatar Dec 21 '20 19:12 chholm