login icon indicating copy to clipboard operation
login copied to clipboard

v1.6.0 Creates warnings when doing azure/login from a composite action.

Open JasonRSeequent opened this issue 2 years ago • 8 comments

When calling azure/[email protected] from a composite action, the following warning is generated:

Warning: `pre` execution is not supported for local action from './.github/actions/deploy-infrastructure '

Example workflow block:

      - name: Deploy Infrastructure
        uses: ./.github/actions/deploy-infrastructure
        with:
          azure_credentials: ${{ secrets.AZURE_CREDENTIALS }}

Example action.yaml file:

name: "Deploy Infrastructure"

inputs:
  azure_credentials:
    description: "Azure service principle credentials"
    required: true

runs:
  using: "composite"
  steps:
    - name: Azure login
      uses: azure/login@v1
      with:
        creds: ${{ inputs.azure_credentials}}

JasonRSeequent avatar Jan 17 '24 20:01 JasonRSeequent

Hi @JasonRSeequent, pre and post steps have not been supported in composite actions yet. This is a highly requested feature, let's track it in https://github.com/actions/runner/issues/1478.

MoChilia avatar Jan 18 '24 01:01 MoChilia

Hi @MoChilia, You are correct that pre and post steps are not currently supported in composite actions, based on the issue you linked, it doesn't look like they will be any time soon. If azure/login@v1 is supported in composite actions, then surely there should be a workaround to avoid having these warnings appear? The other workaround is to pin version v1.5.1, which isn't ideal.

JasonRSeequent avatar Jan 18 '24 20:01 JasonRSeequent

@JasonRSeequent, it's a warning message and won't disrupt break your workflow, right? We'll explore ways to enhance this process, but it may not be of high priority. Thank you for your understanding.

MoChilia avatar Jan 19 '24 00:01 MoChilia

this is not a high prio but annoying a lot of dev's around the world ;)

ViktorDronov avatar Feb 05 '24 18:02 ViktorDronov

Any update on this?

mrvamsidhar-ais avatar Apr 18 '24 22:04 mrvamsidhar-ais

any updates on this?

ViktorDronov avatar Jul 02 '24 14:07 ViktorDronov

FYI - I end up moving this task to my workflow.

mrvamsidhar avatar Jul 02 '24 14:07 mrvamsidhar

Hi @JasonRSeequent & @ViktorDronov & @mrvamsidhar & @Kapsztajn & @MattParkerDev & @marjiemclarin & @Malagari & @h0lybyte & @tim-allen-ck & @MCPx & @gmsantos & @culpinnis & @JonasHuhndorf & @johnstairs & @anrdesai & @KiwiPolarBear & @OlivierSeequent & @thekindly1 & @nicky-lenaers-phoenicks & @daniel-weisse & @ShusukeUmezawa & @astromoose & @asos-tomp & @MortenLohne & @LooseInt & @sperling-apple & @ksperling-apple & @pkreyenb & @CodeReaper ,

we've released a new version v2.2.0. In this version, we removed the pre step and added 2 env variables to enable/disable pre or post cleanup. v2 is aligned with v2.2.0 now. Please try the new version. You can also refer to Enable/Disable the cleanup steps.

YanaXu avatar Sep 18 '24 08:09 YanaXu