login icon indicating copy to clipboard operation
login copied to clipboard

Speed up download time with Webpack

Open mayong43111 opened this issue 4 years ago • 7 comments

I notice that the node_module folder is included in the tag of the publication and need it at run time, but it's very big. I modified to use Webpack to package the project, In my sel-hosted, the Set Up Job step saves 30 seconds. so I recommend using it and remove node_module from tag.

mayong43111 avatar Jan 08 '22 11:01 mayong43111

This PR is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Jan 22 '22 12:01 github-actions[bot]

Hey @mayong43111. Thanks for the contribution. I want to understand your approach better. How are you able to accomplish the performance improvement. I could see some regexes are also being used. Can you help us with that?

BALAGA-GAYATRI avatar Mar 21 '22 10:03 BALAGA-GAYATRI

Hey @mayong43111. Thanks for the contribution. I want to understand your approach better. How are you able to accomplish the performance improvement. I could see some regexes are also being used. Can you help us with that?

Hi @BALAGA-GAYATRI , thanks for your commented . Webpack can scan 'require' in code and package it into one file. But the esprima.js component uses the ‘readfilesys’ method, which Webpack cannot package. So I modified his code in a regexes way. replace it with something Webpack accepts before packaging. Of course the best way is for him to fix the code, Instead of hacking it's code.

reference: https://stackoverflow.com/questions/61680141/webpack-bundle-with-jsonpath-dependency

mayong43111 avatar Mar 22 '22 00:03 mayong43111

approved

spartow avatar Mar 23 '22 16:03 spartow

This PR is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Apr 06 '22 18:04 github-actions[bot]

Can this PR get some love?💘

rdeveen avatar Mar 24 '23 15:03 rdeveen

This PR is idle because it has been open for 14 days with no activity.

github-actions[bot] avatar Apr 07 '23 21:04 github-actions[bot]