kaito icon indicating copy to clipboard operation
kaito copied to clipboard

chore: adapter validation e2e

Open bangqipropel opened this issue 1 year ago • 2 comments

Reason for Change: Add adapter names to the logs in inference API Add log checks in e2e test to check if adapter is loaded successfully

Requirements

  • [ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

bangqipropel avatar Aug 05 '24 23:08 bangqipropel

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.18%. Comparing base (5c30038) to head (1c4122e). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files          30       30           
  Lines        2987     2987           
=======================================
  Hits         1738     1738           
  Misses       1149     1149           
  Partials      100      100           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 09 '24 08:08 codecov[bot]

The changes in test/e2e/preset_test.go and pkg/inference/preset-inferences.go are only for e2e test without changing the mcr image, this can be reviewed for if we can use this way to test it for now.

bangqipropel avatar Aug 09 '24 17:08 bangqipropel