azure-sdk-for-java icon indicating copy to clipboard operation
azure-sdk-for-java copied to clipboard

Test merging feature/spring-boot-3 branch to main branch

Open rujche opened this issue 1 year ago • 26 comments

Description

Draft PR, Don't review. This PR is used to test merging feature/spring-boot-3 branch into main branch.

All SDK Contribution checklist:

  • [ ] The pull request does not introduce [breaking changes]
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ ] I have read the contribution guidelines.

General Guidelines and Best Practices

  • [ ] Title of the pull request is clear and informative.
  • [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

rujche avatar Jun 19 '24 05:06 rujche

API change check

API changes are not detected in this pull request.

azure-sdk avatar Jun 21 '24 02:06 azure-sdk

FYI: After merge main branch to feature/spring-boot-3-prepare-merge-to-main branch. The codes in sdk/spring folder is sync to feature/spring-boot-3 branch.

Here is how I confirm this by Intellij IDEA:

  1. Compare sdk/spring folder in feature/spring-boot-3-prepare-merge-to-main and feature/spring-boot-3 branch:

image

  1. Compare result:

image image

rujche avatar Jun 21 '24 05:06 rujche

Hi, @anuchandy

My purpose

Could you please help to fix the unit test failure in current PR's pipeline:

WindowedSubscriberFluxWindowTest.shouldCancelWorkOnEmptyWindowTruncation:405 expected: but was:

More details

  1. This PR is used to merge feature/spring-boot-3 branch into main branch.
  2. The only change in sdk/core folder is external dependency version update.
  3. Because there is too many files (1300+) changed in this PR, the Files Changed tab in current page is hard to use. You can use Intellij IDEA to view the changes. Here are the screenshots about how to do this:

image image

Another topic

This is another topic, if you don't know the answer, please skip this part, it's not necessary to spend much time to investigate this.

To let you easy reproduce the issue, I created another PR: #40756, which just change the pom files in sdk/core folder like this PR did. But the pipeline failed with another issue. It failed in Build for non-From Source run, so the Run Tests is skipped. Here are the screenshots:

image

I confirmed that the maven command is exactly the same:

image image

I don't know why one is failed by warnings and another one is not:

image

As I said before, please help to fix the pipeline failure first, ignore the Another topic part if you don't know the reason.

rujche avatar Jun 24 '24 01:06 rujche

/azp run java - spring - ci

rujche avatar Jun 24 '24 06:06 rujche

Azure Pipelines failed to run 1 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '24 06:06 azure-pipelines[bot]

/azp run java - spring - tests

Netyyyy avatar Jun 24 '24 06:06 Netyyyy

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '24 06:06 azure-pipelines[bot]

@rujche remove EnableBatchRelease to run ci pipeline because its' template already removed https://github.com/Azure/azure-sdk-for-java/pull/40742/commits/f4b9fc34053c8e97044968fc6cfd01c7611a067a

Netyyyy avatar Jun 24 '24 06:06 Netyyyy

/azp run java - spring - tests

moarychan avatar Jun 28 '24 08:06 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 28 '24 08:06 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jun 28 '24 08:06 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 28 '24 08:06 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 01 '24 02:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 02:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 01 '24 07:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 07:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 01 '24 08:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 08:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 01 '24 09:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 09:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 01 '24 09:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 09:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 02 '24 01:07 moarychan

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Jul 02 '24 01:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 02 '24 02:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 02 '24 02:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 02 '24 04:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 02 '24 04:07 azure-pipelines[bot]

/azp run java - spring - tests

moarychan avatar Jul 02 '24 05:07 moarychan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 02 '24 05:07 azure-pipelines[bot]