azure-sdk-for-cpp icon indicating copy to clipboard operation
azure-sdk-for-cpp copied to clipboard

Tables April Release

Open gearama opened this issue 1 year ago • 2 comments

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • [ ] C++ Guidelines
  • [ ] Doxygen docs
  • [ ] Unit tests
  • [ ] No unwanted commits/changes
  • [ ] Descriptive title/description
    • [ ] PR is single purpose
    • [ ] Related issue listed
  • [ ] Comments in source
  • [ ] No typos
  • [ ] Update changelog
  • [ ] Not work-in-progress
  • [ ] External references or docs updated
  • [ ] Self review of PR done
  • [ ] Any breaking changes?

gearama avatar Apr 03 '24 23:04 gearama

The diff is a mess, not sure why, it could be due to line endings style changes, or due to UTF8 start byte addition/removal

antkmsft avatar Apr 04 '24 00:04 antkmsft

The diff is a mess, not sure why, it could be due to line endings style changes, or due to UTF8 start byte addition/removal

I suspect it's line endings, but I'm not 100% sure - if you ignore whitespace, the diff gets cleaner.

LarryOsterman avatar Apr 04 '24 16:04 LarryOsterman