azure-sdk-for-cpp icon indicating copy to clipboard operation
azure-sdk-for-cpp copied to clipboard

Add version resources to Azure SDK binaries when building on Windows (WAS: Allow specifying binary version for Windows builds)

Open avivanoff opened this issue 2 years ago • 5 comments

Original request:

When building on Windows it would be nice to have the ability to specify version info.

When an Azure SDK package is built as a shared binary (DLL) on Windows, add a version resource which reflects the version of the package.

avivanoff avatar Nov 13 '23 00:11 avivanoff

Could you explain "it would be nice to have the ability to specify version info" a bit more? Do you mean the application manifest? The SDK version preprocessor definitions? Something else? What is a "binary version" in this context?

The SDK source code is intentionally windows version agnostic (as much as is feasible).

LarryOsterman avatar Nov 13 '23 16:11 LarryOsterman

Conditionally include rc file when targeting Windows.

avivanoff avatar Nov 13 '23 18:11 avivanoff

Conditionally include rc file when targeting Windows.

Ah - you want to add a resource file when building the SDK as a shared library (dll).

That makes a certain amount of sense. If you don't mind, let me edit the text to reflect what I believe is your request.

LarryOsterman avatar Nov 13 '23 19:11 LarryOsterman

Yes, thank you.

avivanoff avatar Nov 13 '23 19:11 avivanoff

@LarryOsterman, any updates? Seems like should be easy enough change.

avivanoff avatar May 28 '24 22:05 avivanoff

Hi @avivanoff, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

github-actions[bot] avatar Nov 12 '25 18:11 github-actions[bot]