azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

Remove unsupported SQL Pool Rename/move operation

Open kashyap-kunal opened this issue 2 years ago • 8 comments

ARM API Information (Control Plane)

Synapse supports a set of SQL proxy operation on Synapse side and to create swagger spec for them. As part of this, we also created a swagger for SQL Pool's rename operation but we never supported them. So, to avoid confusion for the customers, Synapse leadership team has decided that we will remove the swagger spec for Rename operation.

This PR takes care of removing the same

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • [ ] new service onboarding
    • [ ] new API version
    • [ ] update existing version for new feature
    • [ ] update existing version to fix swagger quality issue in s360
    • [X] Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: :warning:

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • [ ] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • [x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

kashyap-kunal avatar Jun 20 '23 16:06 kashyap-kunal

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
sqlPool.json 2021-04-01-preview(93e5080) 2021-04-01-preview(main)
sqlPool.json 2021-06-01-preview(93e5080) 2021-06-01-preview(main)
sqlPool.json 2020-12-01(93e5080) 2020-12-01(main)
sqlPool.json 2021-03-01(93e5080) 2021-03-01(main)
sqlPool.json 2021-05-01(93e5080) 2021-05-01(main)
sqlPool.json 2021-06-01(93e5080) 2021-06-01(main)
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L462:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L470:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L462:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L462:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/stable/2021-05-01/sqlPool.json#L462:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Synapse/workspaces/{workspaceName}/sqlPools/{sqlPoolName}/move' removed or restructured?
Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L470:5
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5173:3
Old: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5230:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5317:3
Old: Microsoft.Synapse/preview/2021-06-01-preview/sqlPool.json#L5374:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L5170:3
Old: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L5227:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5173:3
Old: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5230:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/stable/2021-05-01/sqlPool.json#L5173:3
Old: Microsoft.Synapse/stable/2021-05-01/sqlPool.json#L5230:3
1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ResourceMoveDefinition' removed or renamed?
New: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5206:3
Old: Microsoft.Synapse/stable/2021-06-01/sqlPool.json#L5263:3
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
:warning: MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/synapse/resource-manager/readme.md
tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 40 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L246:22
ExampleUrl: preview/2021-04-01-preview/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L246:22
ExampleUrl: preview/2021-04-01-preview/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L368:22
ExampleUrl: preview/2021-04-01-preview/examples/PauseSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L368:22
ExampleUrl: preview/2021-04-01-preview/examples/PauseSqlPool.json
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L430:22
ExampleUrl: preview/2021-04-01-preview/examples/ResumeSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L430:22
ExampleUrl: preview/2021-04-01-preview/examples/ResumeSqlPool.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L1022:22
ExampleUrl: preview/2021-04-01-preview/examples/CreateSqlPoolRestorePoints.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L2922:22
ExampleUrl: preview/2021-04-01-preview/examples/ExecuteSqlPoolVulnerabilityAssessmentScans.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L4812:22
ExampleUrl: preview/2021-04-01-preview/examples/DeleteSqlPoolWorkloadGroup.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/preview/2021-04-01-preview/sqlPool.json#L5085:22
ExampleUrl: preview/2021-04-01-preview/examples/DeleteSqlPoolWorkloadGroupWorkloadClassifer.json
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L246:22
ExampleUrl: stable/2020-12-01/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L246:22
ExampleUrl: stable/2020-12-01/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L368:22
ExampleUrl: stable/2020-12-01/examples/PauseSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L368:22
ExampleUrl: stable/2020-12-01/examples/PauseSqlPool.json
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L430:22
ExampleUrl: stable/2020-12-01/examples/ResumeSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L430:22
ExampleUrl: stable/2020-12-01/examples/ResumeSqlPool.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L1022:22
ExampleUrl: stable/2020-12-01/examples/CreateSqlPoolRestorePoints.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L2922:22
ExampleUrl: stable/2020-12-01/examples/ExecuteSqlPoolVulnerabilityAssessmentScans.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L4809:22
ExampleUrl: stable/2020-12-01/examples/DeleteSqlPoolWorkloadGroup.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2020-12-01/sqlPool.json#L5082:22
ExampleUrl: stable/2020-12-01/examples/DeleteSqlPoolWorkloadGroupWorkloadClassifer.json
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L246:22
ExampleUrl: stable/2021-03-01/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L246:22
ExampleUrl: stable/2021-03-01/examples/DeleteSqlPool.json#L9:16
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L368:22
ExampleUrl: stable/2021-03-01/examples/PauseSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L368:22
ExampleUrl: stable/2021-03-01/examples/PauseSqlPool.json
INVALID_TYPE Expected type but found type object
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L430:22
ExampleUrl: stable/2021-03-01/examples/ResumeSqlPool.json#L9:16
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L430:22
ExampleUrl: stable/2021-03-01/examples/ResumeSqlPool.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L1022:22
ExampleUrl: stable/2021-03-01/examples/CreateSqlPoolRestorePoints.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L2922:22
ExampleUrl: stable/2021-03-01/examples/ExecuteSqlPoolVulnerabilityAssessmentScans.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L4812:22
ExampleUrl: stable/2021-03-01/examples/DeleteSqlPoolWorkloadGroup.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.Synapse/stable/2021-03-01/sqlPool.json#L5085:22
ExampleUrl: stable/2021-03-01/examples/DeleteSqlPoolWorkloadGroupWorkloadClassifer.json
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

Hi, @kashyap-kunal Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?
  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/synapse/armsynapse - 0.8.0
    +	Function `*SQLPoolsClient.Rename` has been removed
    +	Struct `ResourceMoveDefinition` has been removed
    azure-sdk-for-js - @azure/arm-synapse - Approved - 9.0.0-beta.2
    +	Class SynapseManagementClient has a new signature
    +	Class SynapseManagementClient no longer has parameter privateLinkResources
    +	Interface IntegrationRuntimeStatusResponse has a new required parameter type
    +	Interface IntegrationRuntimeStatusResponse no longer has parameter properties
    +	Interface SqlPoolSchemasListNextOptionalParams no longer has parameter filter
    +	Interface SqlPoolSensitivityLabelsListCurrentNextOptionalParams no longer has parameter filter
    +	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter filter
    +	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter includeDisabledRecommendations
    +	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter skipToken
    +	Interface SqlPoolTableColumnsListByTableNameNextOptionalParams no longer has parameter filter
    +	Interface SqlPoolTablesListBySchemaNextOptionalParams no longer has parameter filter
    +	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
    +	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    +	Removed operation SqlPoolOperationResults.getLocationHeaderResult
    +	Removed operation SqlPools.rename
    +	Removed operation SqlPools.update
    +	Removed operation group PrivateLinkResources
    +	Type of parameter actualState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState to ActualState
    +	Type of parameter desiredState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState to DesiredState
    azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - Approved - 2.1.0b7
    +	Removed operation SqlPoolsOperations.rename
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1mGeneratePackage: [0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:881
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m 881 | [0m         [36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [36;1m     | [31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [31;1m[36;1m     | [31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] [0m
      cannot force update branch 'sdkAuto/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
    • ️✔️Azure.ResourceManager.Synapse [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.ResourceManager.Synapse [View full logsBreaking Change Detected
      error	Fatal error: cannot force update branch 'sdkAuto/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		Azure.ResourceManager.Synapse
      error		Azure.ResourceManager.Synapse
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface EventGridDataConnection
      info	[Changelog]   - Added Interface EventHubDataConnection
      info	[Changelog]   - Added Interface ExtendedServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ExtendedSqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface GeoBackupPolicy
      info	[Changelog]   - Added Interface GetIntegrationRuntimeEnableInteractivequeryOptionalParams
      info	[Changelog]   - Added Interface GetIntegrationRuntimeStartOptionalParams
      info	[Changelog]   - Added Interface GetIntegrationRuntimeStopOptionalParams
      info	[Changelog]   - Added Interface IntegrationRuntimeEnableinteractivequery
      info	[Changelog]   - Added Interface IntegrationRuntimeOperationStatus
      info	[Changelog]   - Added Interface IntegrationRuntimeResource
      info	[Changelog]   - Added Interface IntegrationRuntimeStopOperationStatus
      info	[Changelog]   - Added Interface IotHubDataConnection
      info	[Changelog]   - Added Interface IpFirewallRuleInfo
      info	[Changelog]   - Added Interface Key
      info	[Changelog]   - Added Interface KustoPool
      info	[Changelog]   - Added Interface KustoPoolPrivateLinkResources
      info	[Changelog]   - Added Interface KustoPoolPrivateLinkResourcesListOptionalParams
      info	[Changelog]   - Added Interface KustoPoolUpdate
      info	[Changelog]   - Added Interface LibraryResource
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeKeyAuthorization
      info	[Changelog]   - Added Interface LinkedIntegrationRuntimeRbacAuthorization
      info	[Changelog]   - Added Interface MaintenanceWindowOptions
      info	[Changelog]   - Added Interface MaintenanceWindows
      info	[Changelog]   - Added Interface ManagedIdentitySqlControlSettingsModel
      info	[Changelog]   - Added Interface ManagedIntegrationRuntime
      info	[Changelog]   - Added Interface ManagedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface MetadataSyncConfig
      info	[Changelog]   - Added Interface PrivateEndpointConnection
      info	[Changelog]   - Added Interface PrivateEndpointConnectionForPrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkHub
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface PrivateLinkResources
      info	[Changelog]   - Added Interface ProxyResource
      info	[Changelog]   - Added Interface ReadOnlyFollowingDatabase
      info	[Changelog]   - Added Interface ReadWriteDatabase
      info	[Changelog]   - Added Interface RecommendedSensitivityLabelUpdate
      info	[Changelog]   - Added Interface RecoverableSqlPool
      info	[Changelog]   - Added Interface ReplicationLink
      info	[Changelog]   - Added Interface RestorableDroppedSqlPool
      info	[Changelog]   - Added Interface RestorePoint
      info	[Changelog]   - Added Interface SecureString
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntime
      info	[Changelog]   - Added Interface SelfHostedIntegrationRuntimeStatus
      info	[Changelog]   - Added Interface SensitivityLabel
      info	[Changelog]   - Added Interface SensitivityLabelUpdate
      info	[Changelog]   - Added Interface ServerBlobAuditingPolicy
      info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
      info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
      info	[Changelog]   - Added Interface SparkConfigurationResource
      info	[Changelog]   - Added Interface SqlPool
      info	[Changelog]   - Added Interface SqlPoolBlobAuditingPolicy
      info	[Changelog]   - Added Interface SqlPoolColumn
      info	[Changelog]   - Added Interface SqlPoolConnectionPolicy
      info	[Changelog]   - Added Interface SqlPoolOperation
      info	[Changelog]   - Added Interface SqlPoolSchema
      info	[Changelog]   - Added Interface SqlPoolSecurityAlertPolicy
      info	[Changelog]   - Added Interface SqlPoolTable
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessment
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentRuleBaseline
      info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentScansExport
      info	[Changelog]   - Added Interface SsisEnvironment
      info	[Changelog]   - Added Interface SsisFolder
      info	[Changelog]   - Added Interface SsisPackage
      info	[Changelog]   - Added Interface SsisProject
      info	[Changelog]   - Added Interface SubResource
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface TransparentDataEncryption
      info	[Changelog]   - Added Interface VulnerabilityAssessmentScanRecord
      info	[Changelog]   - Added Interface WorkloadClassifier
      info	[Changelog]   - Added Interface WorkloadGroup
      info	[Changelog]   - Added Interface Workspace
      info	[Changelog]   - Added Interface WorkspaceAadAdminInfo
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
      info	[Changelog]   - Added Type Alias ActualState
      info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Type Alias DesiredState
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeEnableInteractivequeryResponse
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStartResponse
      info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStopResponse
      info	[Changelog]   - Added Type Alias KustoPoolPrivateLinkResourcesListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
      info	[Changelog]   - Added Type Alias WorkspaceStatus
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter dataFactoryName
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter state
      info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter resumeFrom
      info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter updateIntervalInMs
      info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Enum KnownWorkspaceStatus
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group PrivateLinkResources
      info	[Changelog]   - Removed operation SqlPoolOperationResults.getLocationHeaderResult
      info	[Changelog]   - Removed operation SqlPools.rename
      info	[Changelog]   - Removed operation SqlPools.update
      info	[Changelog]   - Class SynapseManagementClient has a new signature
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse no longer has parameter properties
      info	[Changelog]   - Interface SqlPoolSchemasListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListCurrentNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter includeDisabledRecommendations
      info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter skipToken
      info	[Changelog]   - Interface SqlPoolTableColumnsListByTableNameNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface SqlPoolTablesListBySchemaNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new required parameter type
      info	[Changelog]   - Type of parameter actualState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState to ActualState
      info	[Changelog]   - Type of parameter desiredState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState to DesiredState
      info	[Changelog]   - Class SynapseManagementClient no longer has parameter privateLinkResources
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
      info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.8.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter os_type
      info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter target_framework
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Removed operation SqlPoolsOperations.rename
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/synapse/armsynapse [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*SQLPoolsClient.Rename` has been removed
      info	[Changelog] - Struct `ResourceMoveDefinition` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - Type of `WorkspaceProperties.ExtraProperties` has been changed from `map[string]any` to `any`
      info	[Changelog] - New field `OSType`, `TargetFramework` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 1 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️synapse [View full logs
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 3731ac6150dcb22856183e9f1ca49eb912459f83. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.synapse.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.synapse.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/synapse/armsynapse https://apiview.dev/Assemblies/Review/539c73c95cc44ace87327675a9c01d05
    Java azure-resourcemanager-synapse https://apiview.dev/Assemblies/Review/8b26ddf5eb824bdab1e3e7957d344fe5
    JavaScript @azure/arm-synapse https://apiview.dev/Assemblies/Review/286ee34acdc142ba912fe88d1f93c23e
    .Net Azure.ResourceManager.Synapse https://apiview.dev/Assemblies/Review/2a14ecc0db7d4fc1a39ad93190a899e2

    Hi @kashyap-kunal, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    Hi @kashyap-kunal, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @kashyap-kunal please fix MV error

    ankhyk avatar Jun 25 '23 02:06 ankhyk

    the third js sdk breaking change is caused by this pr

    kazrael2119 avatar Jul 12 '23 08:07 kazrael2119

    Model Validation Error for existing APIs will be fixed as part of https://powerbi.visualstudio.com/Trident/_workitems/edit/1141089

    kashyap-kunal avatar Jul 15 '23 00:07 kashyap-kunal