azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[Az.RecoveryServices.Backup] Fix AFS Restore Command Bug

Open IannGeorges opened this issue 6 months ago • 12 comments

Description

Implementing fix to handle cases where the source storage account is deleted & required sourceResourceId property is missing for restore request payload.

Tested restore where AFS source storage account was deleted before changes were made to reproduce bug. Tested restore where AFS source storage account was deleted after changes were made to validate fix.

Mandatory Checklist

  • Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

    • [X] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] No need for a release
  • [X] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

IannGeorges avatar Jul 30 '25 06:07 IannGeorges

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

/azp run

YanaXu avatar Jul 31 '25 04:07 YanaXu

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 31 '25 04:07 azure-pipelines[bot]

Hi @IannGeorges please also sync main branch in next commit to keep the changelog updated.

NoriZC avatar Aug 04 '25 08:08 NoriZC

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Aug 05 '25 06:08 github-actions[bot]

@YanaXu @NoriZC can one of you please retrigger the pipeline?

IannGeorges avatar Sep 16 '25 22:09 IannGeorges

/azp run

isra-fel avatar Sep 16 '25 22:09 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Sep 16 '25 22:09 azure-pipelines[bot]

@IannGeorges we've workaround the issue with pipeline triggers - feel free to continue dev work on this PR. Thanks

isra-fel avatar Oct 02 '25 06:10 isra-fel

/azp run

isra-fel avatar Oct 14 '25 00:10 isra-fel

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Oct 14 '25 00:10 azure-pipelines[bot]

@IannGeorges There are still errors in the pipeline, please have a look!

notyashhh avatar Nov 18 '25 04:11 notyashhh