azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Add TLS 1.3 to MinimalTlsVersion

Open jha1bhavna opened this issue 2 years ago • 2 comments

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell

    • [ ] General release
    • [ ] Public preview
    • [ ] Private preview
    • [ ] Engineering build
    • [ ] N/A
  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

jha1bhavna avatar Feb 12 '24 18:02 jha1bhavna

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌ - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Need to update Azure.Core version first

msJinLei avatar Feb 18 '24 03:02 msJinLei

Need to update Azure.Core version first

Where do we update that? to what?

jha1bhavna avatar Feb 20 '24 04:02 jha1bhavna

Need to update Azure.Core version first

Where do we update that? to what?

The "Azure.ResourceManager.Sql" introduce the dependancy of Azure.Core 1.37, which conflicts with the exiting Azure.Core Azure PowerShell uses. What you depend on in Azure.ResourceManager.Sql. You should generate it in your generated SDK.

msJinLei avatar Feb 20 '24 07:02 msJinLei

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Feb 20 '24 07:02 github-actions[bot]

Need to update Azure.Core version first

Where do we update that? to what?

The "Azure.ResourceManager.Sql" introduce the dependancy of Azure.Core 1.37, which conflicts with the exiting Azure.Core Azure PowerShell uses. What you depend on in Azure.ResourceManager.Sql. You should generate it in your generated SDK.

Updated the Azure.Core version to 1.37

jha1bhavna avatar Mar 13 '24 12:03 jha1bhavna