[Compute] Communitygallery changes
Description
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1188
Checklist
- [x] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:
-
SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to
generationbranch. - SHOULD make the title of PR clear and informative, and in the present imperative tense.
-
SHOULD update
ChangeLog.mdfile(s) appropriately- For any service, the
ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md - A snippet outlining the change(s) made in the PR should be written under the
## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch. - Should not change
ChangeLog.mdif no new release is required, such as fixing test case only.
- For any service, the
-
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from the scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
- SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
- SHOULD have proper test coverage for changes in pull request.
- SHOULD NOT introduce breaking changes in Az minor release except preview version.
- SHOULD NOT change version of module in pull request
@isra-fel do you know how to fix this error: ERROR: Assembly Microsoft.Azure.Management.ResourceGraph was not included in the required assemblies field for module Az.Compute
For context, I added a new ResourceGraph assembly through Nuget.
@haagha basically by adding a new reference you need also add the assembly to the "RequiredAssemblies" part of the PSD1 file. Another issue is you need to use the same version of the package as used in other modules, 2.1.0 in your case -- this is because otherwise assemblies with different version will conflict, and will cause Compute and other modules unable to be loaded together in PowerShell.
We'd like to avoid assembly conflict as much as possible. So my question is, is it completely necessary to reference resource graph SDK? Is there a workaround like using ARM template?
Kindly ping @haagha