azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[Compute] Communitygallery changes

Open haagha opened this issue 3 years ago • 2 comments

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1188

Checklist

  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

haagha avatar Aug 02 '22 15:08 haagha

@isra-fel do you know how to fix this error: ERROR: Assembly Microsoft.Azure.Management.ResourceGraph was not included in the required assemblies field for module Az.Compute

For context, I added a new ResourceGraph assembly through Nuget.

haagha avatar Aug 04 '22 11:08 haagha

@haagha basically by adding a new reference you need also add the assembly to the "RequiredAssemblies" part of the PSD1 file. Another issue is you need to use the same version of the package as used in other modules, 2.1.0 in your case -- this is because otherwise assemblies with different version will conflict, and will cause Compute and other modules unable to be loaded together in PowerShell.

We'd like to avoid assembly conflict as much as possible. So my question is, is it completely necessary to reference resource graph SDK? Is there a workaround like using ARM template?

isra-fel avatar Aug 05 '22 05:08 isra-fel

Kindly ping @haagha

isra-fel avatar Aug 16 '22 06:08 isra-fel