azure-functions-java-worker icon indicating copy to clipboard operation
azure-functions-java-worker copied to clipboard

Support "RpcHttpBodyOnly"capability

Open yojagad opened this issue 6 years ago • 9 comments

Host has a "RpcHttpBodyOnly" capability where it does not send duplicated data through gRPC. It only sends the "body" property which is either bytes or string.

Reference PR: Azure/azure-functions-host#4660

Java needs to make modifications on the worker side accordingly in order to decode it whenever necessary.

Also need to support RpcHttpTriggerMetadataRemoved Reference https://github.com/Azure/azure-functions-nodejs-worker/pull/238/files

yojagad avatar Jul 31 '19 00:07 yojagad

cc @mathewc @amamounelsayed / @anirudhgarg - Is it possible to address this issue this sprint? this fix is critical to the perf improvement that @mathewc is working on and specifically he has chosen java worker for making out-of-proc improvements

pragnagopa avatar Apr 27 '20 19:04 pragnagopa

Thanks @pragnagopa for flagging this. @TsuyoshiUshio will be helping on this with @amamounelsayed's help.

anirudhgarg avatar Apr 28 '20 17:04 anirudhgarg

@pragnagopa @anirudhgarg I talked to @mathewc this fix we do our best to have it in this sprint or next one. Thank you so much!

amamounelsayed avatar Apr 28 '20 23:04 amamounelsayed

Hi @yojagad , Let me understand the context for the RpcHttpTriggerMetadataRemoved. I read the code on this https://github.com/Azure/azure-functions-nodejs-worker/pull/238/files Inside of the PR, I found the code set the req and $request in triggerMetadata in case of undefined/null. Why do we need it? I can implement it on Java, however, I want to understand the context.

TsuyoshiUshio avatar Apr 29 '20 06:04 TsuyoshiUshio

@yojagad Self Resolved. :) Never mind. I'll create a PR.

TsuyoshiUshio avatar Apr 29 '20 16:04 TsuyoshiUshio

https://github.com/Azure/azure-functions-java-worker/pull/364

amamounelsayed avatar May 05 '20 22:05 amamounelsayed

@pragnagopa @amamounelsayed Can we close this issue? or keep until the functions host is released?

TsuyoshiUshio avatar May 13 '20 05:05 TsuyoshiUshio

@TsuyoshiUshio, The reason is not closed it is not released yet. @anirudhgarg point to not create confusion, so we close it after release.

amamounelsayed avatar May 13 '20 16:05 amamounelsayed

Hi @amamounelsayed - could you confirm if this issue can be closed?

MadhuraBharadwaj-MSFT avatar Jun 27 '23 02:06 MadhuraBharadwaj-MSFT