azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

[APIM] Add parameters to APIM create/update command

Open yingru97 opened this issue 3 years ago • 1 comments

Related command

Description

Add parameters to allow users to to set "disable_gateway" and "public_network_access" properties of apim service

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

yingru97 avatar Sep 23 '22 00:09 yingru97

APIM

yonzhan avatar Sep 23 '22 00:09 yonzhan

@yingru97 Could you please resolve those conflicts?

zhoxing-ms avatar Oct 08 '22 12:10 zhoxing-ms

@yingru97 Please refer to this guideline to add the specific description of those new parameters in the PR description

zhoxing-ms avatar Oct 08 '22 12:10 zhoxing-ms

Could you please address those comments in time? Please note that if you can't resolve all the comments by tomorrow, this PR will not be able to catch up with the release of this sprint. We can only postpone it to the next sprint (11-01)

zhoxing-ms avatar Oct 08 '22 12:10 zhoxing-ms

@yingru97 Could you add some test cases for the new parameter --disable-gateway?

zhoxing-ms avatar Oct 25 '22 08:10 zhoxing-ms

@yingru97 I updated the PR title and PR description for you, please see if they meet your expectations

zhoxing-ms avatar Oct 25 '22 08:10 zhoxing-ms

@yingru97 Since we will launch the release of this sprint tomorrow, please address all the comments before tomorrow, otherwise this PR will not be able to catch up with the release of this sprint, and it can only be postponed to the next sprint (12-06)

zhoxing-ms avatar Oct 26 '22 10:10 zhoxing-ms