az aks create --node-osdisk-type is improperly validating values

[phealy]

Describe the bug

If the value to --node-osdisk-type is not exactly Managed or Ephemeral (case sensitive, too), the input is ignored. No error is given for an invalid value to this argument - example, --node-osdisk-type BOGUS will create a cluster, but using whatever the default is.

Additionally, the documentation for the argument says:

OS disk type to be used for machines in a given agent pool. Defaults to 'Managed'.
May not be changed for this pool after creation.

This is no longer true; per the documentation when a user does not explicitly request managed disks for the OS, AKS will default to ephemeral OS if possible for a given node pool configuration.

Command Name az aks create Extension Name: aks-preview. Version: 0.5.47.

Errors: None, that's the problem!

To Reproduce:

Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

• az aks create -l eastus -c 1 --node-osdisk-size 64 -s Standard_E16ds_v4 --no-wait -n e4lower --node-osdisk-type managed
• az aks create -l eastus -c 1 --node-osdisk-size 64 -s Standard_E16ds_v4 --no-wait -n e4junk --node-osdisk-type BOGUSVALUE

Expected Behavior

• if a bad value is specified: an error is emitted
• if a correct but non-camel-case value is specified: validation succeeds and uses the appropriate value

Environment Summary

Linux-5.11.0-1022-azure-x86_64-with-debian-bullseye-sid, Ubuntu 20.04.3 LTS
Python 3.6.10
Installer: DEB

azure-cli 2.32.0

Extensions:
fzf 1.0.2
aks-preview 0.5.48

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

[phealy]

@alexeldeib would this be in your area?

[ghost]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/aks-pm.

Issue Details

---

Describe the bug

If the value to --node-osdisk-type is not exactly Managed or Ephemeral (case sensitive, too), the input is ignored. No error is given for an invalid value to this argument - example, --node-osdisk-type BOGUS will create a cluster, but using whatever the default is.

Additionally, the documentation for the argument says:

OS disk type to be used for machines in a given agent pool. Defaults to 'Managed'.
May not be changed for this pool after creation.

This is no longer true; per the documentation when a user does not explicitly request managed disks for the OS, AKS will default to ephemeral OS if possible for a given node pool configuration.

Command Name az aks create Extension Name: aks-preview. Version: 0.5.47.

Errors: None, that's the problem!

To Reproduce:

Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

• az aks create -l eastus -c 1 --node-osdisk-size 64 -s Standard_E16ds_v4 --no-wait -n e4lower --node-osdisk-type managed
• az aks create -l eastus -c 1 --node-osdisk-size 64 -s Standard_E16ds_v4 --no-wait -n e4junk --node-osdisk-type BOGUSVALUE

Expected Behavior

• if a bad value is specified: an error is emitted
• if a correct but non-camel-case value is specified: validation succeeds and uses the appropriate value

Environment Summary

Linux-5.11.0-1022-azure-x86_64-with-debian-bullseye-sid, Ubuntu 20.04.3 LTS
Python 3.6.10
Installer: DEB

azure-cli 2.32.0

Extensions:
fzf 1.0.2
aks-preview 0.5.48

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

Author:	phealy
Assignees:	-
Labels:	Service Attention, AKS
Milestone:	-

[yonzhan]

route to service team

[mbifeld]

Hey @phealy, is this issue still relevant?

[mbifeld]

Closing as outdated based on comment above. Please ping/reopen if this should still be an active issue. Thanks!