azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

chore: do not use network_plugin default from sdk

Open tyler-lloyd opened this issue 1 year ago • 7 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

the cli should not set network_plugin defaults. it should let the AKS RP handle defaulting.

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

tyler-lloyd avatar Jul 01 '24 20:07 tyler-lloyd

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @tyler-lloyd, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Hi @tyler-lloyd, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Jul 01 '24 20:07 yonzhan

:warning: Release Suggestions

Module: aks-preview

  • :warning: Please log updates into to src/aks-preview/HISTORY.rst
  • Update VERSION to 5.0.0b4 in src/aks-preview/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Jul 01 '24 20:07 github-actions[bot]

Failures in the CI check are not related to the change, will fix in another PR #7775

FumingZhang avatar Jul 03 '24 06:07 FumingZhang

#7775 merged, please rebase from main

FumingZhang avatar Jul 03 '24 06:07 FumingZhang

@FumingZhang - looks like CI is passing now. thanks for the fix.

tyler-lloyd avatar Jul 08 '24 15:07 tyler-lloyd

@zhoxing-ms PTAL

tyler-lloyd avatar Jul 09 '24 11:07 tyler-lloyd