azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[containerapp] Fix telemetry collection when using local builder

Open cormacpayne opened this issue 2 years ago • 5 comments

Currently, when containerapp create/update/up are called and the provided source is built locally using the builder, the previously set value for collect_telemetry within the Azure CLI is not respected when running the builder. This PR will set the ORYX_DISABLE_TELEMETRY environment variable on the builder if it's found that the user previously disabled telemetry collection.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create az containerapp update az containerapp up

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

~- [ ] My extension description/summary conforms to the Extension Summary Guidelines.~

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

cormacpayne avatar Dec 14 '23 16:12 cormacpayne

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @cormacpayne, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

containerapp

yonzhan avatar Dec 14 '23 16:12 yonzhan

For the reviewer:

It looks like the CI is failing for a couple of reasons:

  • The azdev style containerapp is failing in the pipeline, but when I run it locally against main and my branch for this PR, both report the same score, so it doesn't appear any style changes have been added/removed as a part of this PR, so I'm not sure why that part of CI is failing
  • The Python integration tests are failing for a test that's independent from the changes I made, so I'm not sure if it was a flaky test and should be re-ran

cormacpayne avatar Dec 14 '23 21:12 cormacpayne

For the reviewer:

It looks like the CI is failing for a couple of reasons:

  • The azdev style containerapp is failing in the pipeline, but when I run it locally against main and my branch for this PR, both report the same score, so it doesn't appear any style changes have been added/removed as a part of this PR, so I'm not sure why that part of CI is failing
  • The Python integration tests are failing for a test that's independent from the changes I made, so I'm not sure if it was a flaky test and should be re-ran

please try to rerun the failed test in live mode and upload the re-recording file.

yanzhudd avatar Dec 18 '23 07:12 yanzhudd