azure-cli-dev-tools icon indicating copy to clipboard operation
azure-cli-dev-tools copied to clipboard

Support azdev test to auto cleanup pyc files and recordings when live test failed

Open YalinLi0312 opened this issue 5 years ago • 5 comments

For issue #208

YalinLi0312 avatar Nov 12 '20 03:11 YalinLi0312

@haroldrandom to help with.

yonzhan avatar Nov 12 '20 04:11 yonzhan

@haroldrandom This PR is literally split out from previous big PR, it has addressed your comments there, and excludes the multi-process implementation. Do you have any new comments? Could we wrap up this week?

YalinLi0312 avatar Nov 30 '20 23:11 YalinLi0312

Does recording file have debug info that is useful?

qwordy avatar Dec 01 '20 02:12 qwordy

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

YalinLi0312 avatar Dec 01 '20 17:12 YalinLi0312

Does recording file have debug info that is useful?

I don't quite understand your question. The content of recordings are same as before, and this PR is changing the behavior when test failed.

This PR removes recording files when a test fails. Right? Is it possible that people need the recording files to debug?

qwordy avatar Dec 02 '20 03:12 qwordy