avdaccelerator icon indicating copy to clipboard operation
avdaccelerator copied to clipboard
verified publisher icon Azure

US 30535 - Terraform - FSLogix with ADDS v2 #429

Open sihbher opened this issue 2 years ago • 5 comments

Overview/Summary

Adds the Management VM module to Terraform, including joining the storage account to the domain and a user assigned managed identity.

This PR fixes/adds/changes/removes

  1. Adds Mgmt VM module to Terraform workload.
  2. Adds some variables used for Mgmt VM

Testing Evidence

image image

As part of this Pull Request I have

  • [ ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • [ ] Checked for duplicate Pull Requests
  • [ ] Associated it with relevant GitHub Issues
  • [ ] (AVD LZA Team Only) Associated it with relevant ADO Items
  • [ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ ] Performed testing and provided evidence.
  • [ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

sihbher avatar Jan 11 '24 17:01 sihbher

Talked to @danycontre and I added a feature to run custom script "Set-SessionHostConfiguration.ps1" in order to configure fslogix on for every host.

image image

sihbher avatar Jan 12 '24 23:01 sihbher

@jensheerin checking with you on this one.

danycontre avatar Jan 29 '24 14:01 danycontre

do not merge until review is completed.

jensheerin avatar Feb 06 '24 02:02 jensheerin

also run fmt

jensheerin avatar Feb 09 '24 20:02 jensheerin

@jensheerin I've done the requested adjustments, please review

sihbher avatar Feb 12 '24 17:02 sihbher