ResourceModules icon indicating copy to clipboard operation
ResourceModules copied to clipboard

[Modules] Multi additions to staticSites

Open AlexanderSehr opened this issue 3 years ago • 1 comments

Description

Based on PR by @itpropro #1655

Added the following to staticSites

  • config (app config and function app config)
  • customDomains with different validations depending on apex or not
  • linkedBackends with the 2022-03-01 API to add custom function apps. The userDefinedFunctions endpoint should not be used and is currently broken.

Changes were verified, pester and deployment tested with the respective PowerShell functions. Readme and parameter files have been updated.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Web: StaticSites

Type of Change

Please delete options that are not relevant.

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Update to documentation

AlexanderSehr avatar Jul 12 '22 08:07 AlexanderSehr

Unit Test Results

    1 files  ±    0      1 suites  ±0   1m 17s :stopwatch: +56s 165 tests +143  161 :heavy_check_mark: +140  4 :zzz: +3  0 :x: ±0  172 runs  +150  167 :heavy_check_mark: +146  5 :zzz: +4  0 :x: ±0 

Results for commit 372fd69d. ± Comparison against base commit b1101a21.

This pull request removes 22 and adds 165 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] folder should contain one or more *parameters.json files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [.test] folder
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should have a GitHub workflow
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Network/connections] Module should have an Azure DevOps pipeline
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Parameter file tests.Deployment test file tests.[Microsoft.Network/connections] Bicep test deployment files should invoke test like [module testDeployment '../.*deploy.bicep' = {]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Parameter file tests.Deployment test file tests.[Microsoft.Network/connections] Bicep test deployment name should contain [-test-]
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/config] used resource type [staticSites/config] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/customDomains] used resource type [staticSites/customDomains] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites/linkedBackends] used resource type [staticSites/linkedBackends] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/config] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/customDomains] should use one of the recent API version(s). Currently using [2022-03-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Web/staticSites] used resource type [staticSites/linkedBackends] should use one of the recent API version(s). Currently using [2022-03-01]
…
This pull request removes 1 skipped test and adds 4 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/connections] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/config] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/customDomains] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Web/staticSites/linkedBackends] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Web/staticSites] *parameters.json files in the .test folder should be valid json

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 12 '22 08:07 github-actions[bot]

@eriqua and @MrMCake can we finally close this PR? The pipeline is failing because of the word "id" is not in uppercase in the linked backends readme, maybe someone can do a quick fix here. Besides that, there is nothing left and I would really like to consume the changes from this module 😅

itpropro avatar Sep 24 '22 20:09 itpropro

Hey @itpropro, I'll take care of it once #1898 is in to make it as easy for me as possible resolving conflicts. Should happen in the next couple days.

AlexanderSehr avatar Sep 27 '22 16:09 AlexanderSehr

Hey @itpropro, I'll take care of it once #1898 is in to make it as easy for me as possible resolving conflicts. Should happen in the next couple days.

@MrMCake, @itpropro PR #1898 is approved and ready to be merged.

eriqua avatar Sep 27 '22 19:09 eriqua

Merged and retesting

AlexanderSehr avatar Sep 27 '22 19:09 AlexanderSehr