Azure
[Feature Request]: Discuss rolling out the <<resourceGroupName>> token across all pipeline parameter files
Description
We currently support a token called <<resourceGroupName> which is replaced by the resourceGroupName variable in the global variables YAML.
If someone wants to change the resource group name to not be validation-rg, then they'd need to update all pipelines to do that as it is hardcoded in the parameter files.
Should we roll this token out to all parameter files to allow changing the resource group name without impacting the parameter files?
Ideally, it should be fully dynamic so that we have automation to just make all the variables in the global.variable.yml file available as tokens.
The changes you have here was initially requested in #953 and #807. Would be great to have all combined into one, available as tokens or variables in the pipeline/workflows.
Could we however call the variable something along the lines of validationRGName so its aligned with the rest of the variables? So that the current...
resourceGroupName: 'validation-rg' # The default resource group to test deployment resources into
Becomes:
validationRGName: 'validation-rg' # The default resource group to test deployment resources into
Maybe we should also call the global.variables.yml -> settings.yml and move enableDefaultTelemetry to this file as the #1440 might render the "namePrefix" obsolete.
@MariusStorhaug global.variables.yml will be settings.yml as per your suggestion.
@MariusStorhaug on your point: Ideally, it should be fully dynamic so that we have automation to just make all the variables in the global.variable.yml file available as tokens.
In the case of GitHub, we are taking the whole file and injecting it as environment variables. Is the above alluding to taking each environment variable, appending the token prefix and suffix and then searching for it in the file? like this:
<<envVariable1>>
@ahmadabdalla, then I think I was unaware of how the tokens were made available in the piepline/workflows. My bad. You can disregard the point made on making them automatically available as env vars.
While I think this could be enabled at any time - I wonder if it is still relevant once the new dependency approach #1791 is merged for all modules. There, the resource group name is usually passed as a reference in to the test.
Any thoughts @ahmadabdalla ? I guess it wouldn't hurt to have the replacement anyhow? :D
@MrMCake with a recent feedback I got from a carml customer is that changing the RG name on the settings.yml doesn't reflect in the parameter files. Would there still be any use cases for the dependency pipelines to continue to be supported? If yes, then maybe we can roll this out?
If yes, then maybe we can roll this out?
Currently, there would not be a use case for the dependency pipeline to be supported in the future.
@MrMCake then we can close this ticket if there is no longer a need for it
Moving back to needs triage to agree on this closure. I'd anyway suggest to open a new issue to remove the resource group parameter from settings.yml and all related utility referencies.
