LogicAppsUX icon indicating copy to clipboard operation
LogicAppsUX copied to clipboard

Array editor for attachment field in Send email changes to advanced view

Open kisubedi opened this issue 1 year ago • 4 comments

Describe the Bug with repro steps

More details here: Bug 29031182: [v3] [LAUX] Array editor for attachment field in Send email changes to advanced view

What type of Logic App Is this happening in?

Consumption (Portal)

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

No response

Browser

Chrome

Additional context

No response

kisubedi avatar Aug 08 '24 21:08 kisubedi

@hartra344 Is this something the team will be taking on? I want to make sure we don't duplicate work so wanted an explicit ack if this won't be tackled by LAUX team soon.

Aleks-gdb avatar Sep 19 '24 17:09 Aleks-gdb

I think this might have been a regression that has happened when PA moved the serializing array editor to not include quotes if value is just a token https://github.com/Azure/LogicAppsUX/pull/4670. The issue is that it is broken in our deserializing logic because it depends on these quotes in our json parse logic. For the future, for any serialization logic lets make sure to test both serialization and deserilization

Eric-B-Wu avatar Sep 19 '24 20:09 Eric-B-Wu

I think PA should take first pass just due to time constraints on LAUX side, but I think we can just wrap single tokens with quotes when deserializing so that the parse still works

Eric-B-Wu avatar Sep 19 '24 20:09 Eric-B-Wu

That makes a lot of sense. Thank you for the pointers! We will have someone on PAuto address this.

Aleks-gdb avatar Sep 19 '24 20:09 Aleks-gdb