LogicAppsUX icon indicating copy to clipboard operation
LogicAppsUX copied to clipboard

Parameters wiped after saving an update

Open AndrewSCD opened this issue 1 year ago • 2 comments

Describe the Bug with repro steps

I made a change to a logic app which somehow resulted in all parameter fields for all SQL stored procedures being cleared, and possibly other parameters as well (I didn't check these before reverting to a previous version).

Below are the steps I took when this bug occurred.

  1. Go To "Logic App Designer"
  2. Update a "Append to array variable" action on a parallel branch to only run after the previous action only when the previous action Has Timed Out or Has Failed.
  3. Save the Logic App.

Note that on the previous version I'd saved, I'd created 4 parallel branches each with an "Append to array variable", and set the three other actions to Run After as per the above. It was only when I came in this morning and realised the last action hadn't been set correctly that I took the above actions.

Also note that after reverting to a previous version, and repeating the above steps, this bug did not occur again.

What type of Logic App Is this happening in?

Consumption (Portal)

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

No response

Browser

Microsoft Edge

Additional context

No response

AndrewSCD avatar May 03 '24 10:05 AndrewSCD

I've had a very similar issue with a "Send email (v2)" action in the Logic Apps designer. Trying to change the field I display in the body of the email. It keeps going back to the old value.

https://github.com/Azure/LogicAppsUX/assets/7746030/0ab76c0d-f2a0-42ac-9687-23ee24eda631

rogerhillgsy avatar May 08 '24 12:05 rogerhillgsy

Thank you @AndrewSCD and @rogerhillgsy for reporting these issues. I'm going to split up these 2 issues, as while they both relate to saving - they seem to reference different parts.

  1. @AndrewSCD I'm trying to reproduce this issue you're seeing; however I don't seem to be able to. Do you have a part of your workflow json that you could share with me at [email protected]?
  2. @rogerhillgsy there seems to be a regression in the new release where one of our partner teams had added a feature, but seemed to break this token experience. I've gone ahead and reverted their change, and hotfixed it to the new release. If you're still experiencing the issue, please let me know and I'll address it.

Eric-B-Wu avatar May 09 '24 15:05 Eric-B-Wu

@Eric-B-Wu Thank you for your taking a look. After thinking about what happened, I have a theory about why this issue occurred that is not directly tied to the specific actions I took.

At the time, I was experiencing a lot of slowness using the browser that a restart later that day fixed, and this slowness was especially evident when using the Logic App designer. I beleive that when I loaded up the designer and made my change, because it was such a quick change to make, the UI had not yet loaded into memory all the parameters for each action; Thus when I saved my change, it saved some actions without the parameters included.

However, if you think it would still be useful to share the section of code where I made my change, I can send that across for you to review.

AndrewSCD avatar May 22 '24 09:05 AndrewSCD

@Eric-B-Wu Thank you for your taking a look. After thinking about what happened, I have a theory about why this issue occurred that is not directly tied to the specific actions I took.

At the time, I was experiencing a lot of slowness using the browser that a restart later that day fixed, and this slowness was especially evident when using the Logic App designer. I beleive that when I loaded up the designer and made my change, because it was such a quick change to make, the UI had not yet loaded into memory all the parameters for each action; Thus when I saved my change, it saved some actions without the parameters included.

However, if you think it would still be useful to share the section of code where I made my change, I can send that across for you to review.

Sorry for the late response, I've been out of office for the last 3 weeks. Its very possible what happened then is that the api to save never completed/ sent an incomplete workflow and thus never actually saved. If you'd like you can feel free to send over the workflow.json (or second of the code) to [email protected] and I can take a look again, and try to repro the issue on a throttled network. That being said, given that this was a one-time occurrence, if I'm not able to repro it - there likely isn't much I can do to investigate further

Eric-B-Wu avatar Jun 10 '24 11:06 Eric-B-Wu

closing due to inactivity

Eric-B-Wu avatar Jul 16 '24 17:07 Eric-B-Wu