BatchExplorer icon indicating copy to clipboard operation
BatchExplorer copied to clipboard

Add AccountService and CacheManager

Open wanghoppe opened this issue 1 year ago • 1 comments

wanghoppe avatar Jul 02 '24 23:07 wanghoppe

Codecov Report

Attention: Patch coverage is 91.57303% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (225ef88) to head (fdb6a42).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2920      +/-   ##
==========================================
+ Coverage   67.50%   67.62%   +0.12%     
==========================================
  Files        1262     1269       +7     
  Lines       34257    34418     +161     
  Branches     6303     6325      +22     
==========================================
+ Hits        23124    23276     +152     
- Misses      10963    10970       +7     
- Partials      170      172       +2     
Files Coverage Δ
packages/bonito-core/src/cache/cache-manager.ts 100.00% <100.00%> (ø)
packages/bonito-core/src/cache/cache-utils.ts 100.00% <100.00%> (ø)
packages/bonito-core/src/cache/index.ts 100.00% <100.00%> (ø)
...ages/bonito-core/src/cache/memory-cache-manager.ts 100.00% <100.00%> (ø)
...ackages/bonito-core/src/environment/environment.ts 100.00% <100.00%> (ø)
...es/bonito-core/src/environment/mock-environment.ts 87.17% <100.00%> (+0.69%) :arrow_up:
packages/bonito-core/src/service/operations.ts 16.66% <ø> (ø)
...ckages/service/src/account/fake-account-service.ts 100.00% <100.00%> (ø)
...ckages/service/src/account/live-account-service.ts 100.00% <100.00%> (ø)
...ages/service/src/environment/batch-dependencies.ts 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 225ef88...fdb6a42. Read the comment docs.

codecov[bot] avatar Jul 03 '24 18:07 codecov[bot]

Regarding to return undefined when we see a 404. In real case, like in the vm extensions list blade, should we still throw an exception when the account is not found?

wanghoppe avatar Jul 10 '24 19:07 wanghoppe