BatchExplorer icon indicating copy to clipboard operation
BatchExplorer copied to clipboard

fix: Create button for storage container under data menu is broken

Open wanghoppe opened this issue 3 years ago • 1 comments

Fix: AB#1011, To repro can see AB#609

wanghoppe avatar Oct 13 '22 09:10 wanghoppe

Codecov Report

Merging #2579 (f310925) into master (ab5bf75) will decrease coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head f310925 differs from pull request most recent head 18e4044. Consider uploading reports for the commit 18e4044 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2579      +/-   ##
==========================================
- Coverage   64.99%   64.99%   -0.01%     
==========================================
  Files         915      915              
  Lines       26371    26368       -3     
  Branches     5193     5192       -1     
==========================================
- Hits        17139    17137       -2     
+ Misses       9232     9231       -1     
Impacted Files Coverage Δ
...-flask/ui/buttons/clickable/clickable.component.ts 97.91% <ø> (+1.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab5bf75...18e4044. Read the comment docs.

codecov[bot] avatar Oct 13 '22 09:10 codecov[bot]

Using <bl-button> and matMenuTriggerFor directive together has the problem and deleting those codes in PR fixes it. It seems that the add button in the data Menu is the only use case, so hopefully it won't break others

wanghoppe avatar Oct 24 '22 09:10 wanghoppe

Fixed #2636

cRui861 avatar Feb 01 '23 19:02 cRui861