BatchExplorer icon indicating copy to clipboard operation
BatchExplorer copied to clipboard

Add deprecation warning for windowsserver container images

Open cRui861 opened this issue 3 years ago • 1 comments

Deprecation warning will appear for:

  • When a windowsserver container image is selected while creating a new pool: image
  • Existing pools using any of the container images that will be deprecated: image

Warning will not be displayed if other OS are selected for the create new pool experience or existing pools: image

image

cRui861 avatar Sep 16 '22 00:09 cRui861

Codecov Report

Merging #2574 (7565f7e) into master (4c5f3a5) will decrease coverage by 0.16%. The diff coverage is 17.77%.

:exclamation: Current head 7565f7e differs from pull request most recent head 0a1ad64. Consider uploading reports for the commit 0a1ad64 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2574      +/-   ##
==========================================
- Coverage   65.03%   64.87%   -0.17%     
==========================================
  Files         916      916              
  Lines       26406    26493      +87     
  Branches     5207     5227      +20     
==========================================
+ Hits        17174    17188      +14     
- Misses       9232     9305      +73     
Impacted Files Coverage Δ
src/app/models/pool-os-skus.ts 100.00% <ø> (ø)
src/app/utils/pool-utils.ts 76.57% <10.00%> (-6.60%) :arrow_down:
...l/action/add/pool-create-basic-dialog.component.ts 11.42% <15.62%> (+1.24%) :arrow_up:
.../components/pool/details/pool-details.component.ts 17.70% <16.27%> (-2.67%) :arrow_down:
...icker/os-image-picker/os-image-picker.component.ts 79.74% <50.00%> (-0.52%) :arrow_down:
...ob/action/add/pool-picker/pool-picker.component.ts 96.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c5f3a5...0a1ad64. Read the comment docs.

codecov[bot] avatar Sep 16 '22 00:09 codecov[bot]

On the pool overview, can we tweak the message slightly? Something like:

"This pool's image is nearing its end-of-life date of $DATE. After this date, new nodes may not function properly."

(This could probably use some more word-smithing)

dpwatrous avatar Nov 03 '22 17:11 dpwatrous

On the pool overview, can we tweak the message slightly? Something like:

"This pool's image is nearing its end-of-life date of $DATE. After this date, new nodes may not function properly."

(This could probably use some more word-smithing)

Kept it mostly the same but moved the actual date to the second sentence: "This pool's image is nearing its end-of-life date. After $DATE, new nodes may not function properly."

cRui861 avatar Nov 03 '22 21:11 cRui861

Fixed #2635

cRui861 avatar Feb 01 '23 19:02 cRui861