feat: add Playbooks/Enrich-AzureResourceGraph
Change(s):
- add Playbooks/Enrich-AzureResourceGraph
Reason for Change(s): This LogicApp is querying Azure ResourceGraph and return typical azure information related to the resource like subscription, resourcegroup, tags and management groups. It is encapsulated in other Logic app to enrich Sentinel incident (like Enrich-AzureResourceGraph-Incident).
Testing Completed:
- Yes. used in production for many months
Checked that the validations are passing and have addressed any issues that are present:
- Yes. Deployed in production with Sentinel Repository feature, precommit and psrule
Hi @juju4, can you please address @rahul0216's comment?
Hi @juju4, can you please address @rahul0216's comment?
ARM template prerequisites has
"1. Set service principal with Reader role to query resourcegraph.\n2. Set keyvault to store client id and secret.\n3. Pass those parameters at deployment time."
Readme had
- Service principal client id and secret stored in Azure keyvault (Possible change to Managed Identity as supported by HTTP block)
Slightly edited the later to add expected keyvault secret names.
Please withold on merge as I'm reviewing playbook to have resourcegraph as a an optional playbook parameter.
@juju4 I'll wait for your confirmation before approving this PR, as you may have some changes.
Hi @juju4, waiting for confirmation from your side.
Hi @juju4, can you please provide confirmation?
Please give me one or two weeks to work on testing.
Hi @juju4, thanks for acknowledging.
Code and docs update but as per support delay, I won't be able to test until an extra week. So probably 2 weeks more before giving go.
@juju4, Thanks for updating us.
Hi @juju4, is there any update on this PR?
updated pushed. Thanks for your patience.
Hi @juju4, please act on @rahul0216's comments. Thanks
Playbook deployment is failing with following error when there is no tenant id provided,
Fixed but that means Playbooks/Notify-ASCAlertAzureResource/azuredeploy.json is likely broken as it was following same parameter model.
Last update deploys fine but is not functional. Tenant parameter not replaced in url path. I wonder if there is a recommended way to handle that or a working model template unlike Playbooks/Notify-ASCAlertAzureResource
@juju4 parameter values are replaced during execution. Did you run the playbook and test after update? You can refer this playbook, https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Australian%20Cyber%20Security%20Centre/Playbooks/AusCtisExportTaggedIndicators/azuredeploy.json
It is not exact scenario but it may give you an idea how parameters are used in logic app. Also, Please attach a screenshot of successful run once you have one.
Hi @juju4, please look into Rahul's comment, please work on the requested changes.
Hi @juju4, please look into Rahul's comment and act on it accordingly.
Hi @juju4, waiting for some update from you on this PR
Hi @juju4, please act on this PR.
Hi @juju4, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions/feedback shared. Please feel free to reach out to us for any queries and/or support.
fix for tenantid done. tested in deployment pipeline and run. should be good for merge.
@juju4 Thanks for the updates. These looks good. Can you please share screenshot of a successful run?
Here are some screenshots