Added solution for Vectra Cloud
Required items, please complete
Change(s):
- Added Vectra Cloud Solution for certification
Reason for Change(s):
- New Product
Version Updated:
- Initial Version
Testing Completed:
- Yes
Checked that the validations are passing and have addressed any issues that are present:
- Yes
@microsoft-github-policy-service agree company="Vectra"
Hello @dhruvilbhatt-crest please go through the above comment and clear merge conflicts
Hello @devikamehra and @oshezaf author has made the changes
Hello @devikamehra any updates on this
Hello @devikamehra waiting for your updates
Hello @dhruvilbhatt-crest please remove branch conflicts as well
@v-prasadboke @devikamehra All the comments have been addressed and the merge conflict is resolved.
Hello @devikamehra waiting for your approval
@v-prasadboke I am working on adding required fields to test scenarios and will approve post that. @dhruvilbhatt-crest Not necessary, but a suggestion. Can we add EventSeverity based on EventResult field.
Thank you @devikamehra
Hi @devikamehra ,
Thank you for your suggestion, but we discussed it internally, and we didn't find this useful. We will keep this in mind in the future.
@devikamehra @v-prasadboke All the comments have been addressed. Do we have any updates on this?
Also please update the api version of Microsoft.Resources/templateSpecs - 2021-05-01 to 2022-02-01. And the create ui and maintemplate inside the zip package and outside the zip should be identical. After the change please update the zip as well
Hello @dhruvilbhatt-crest lookin in it
@v-prasadboke @devikamehra Do we have any update here?
@dhruvilbhatt-crest There is a PR pending to be merged for whitelisting the required strings in tests https://github.com/Azure/Azure-Sentinel/pull/8047
@devikamehra Since the PR #8047 is merged, can you approve this if nothing is pending for review?
@v-prasadboke @devikamehra Any updates on this PR?
Hi @v-prasadboke @devikamehra,
Can we have some updates here?
Thanks for confirming Devika.
@v-prasadboke Can you provide approval if it's reviewed?
Hello @dhruvilbhatt-crest ,Just to make sure the workbook images you have added are working right??
And Please update the api version of maintemplate. After the updating the api version please update the zip with the latest create ui and maintemplate, This is the only change requested other than this everything looks good.
@v-prasadboke Yes, the images are working. Also, the API version has been updated in the maintemplate and zip file.
@v-prasadboke Are we good to merge this PR? Customers are eagerly waiting on this.
@v-prasadboke Are we good to merge this PR? Customers are eagerly waiting on this.
Hello @dhruvilbhatt-crest looks like you still havent updated the API version, please update the api version of Microsoft.OperationalInsights/workspaces/savedSearches which is 2021-06-01 and replace it with 2022-10-01
After updating the main template please update the zip with the latest maintemplate and createui
Hello @dhruvilbhatt-crest please update the api version in maintemplate
@v-prasadboke Updated the API version. Let me know if we are good to merge this or what all changes are required to get this merged.
Hello @dhruvilbhatt-crest please add the workbook metadata in the ' workbookmetadata ' file in the given path. https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V2/WorkbookMetadata/WorkbooksMetadata.json
@v-prasadboke Updated the workbook metadata.
@v-prasadboke Any update on the PR?