Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

DCRs \ collect net protect events

Open swiftsolves-msft opened this issue 2 years ago • 6 comments

DCR for collecting MDE's Network protect events from devices.

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


swiftsolves-msft avatar Mar 27 '23 20:03 swiftsolves-msft

Hello @v-sabiraj please look into this

v-prasadboke avatar Mar 30 '23 10:03 v-prasadboke

@v-sabiraj, please look into this

v-rbajaj avatar Apr 04 '23 10:04 v-rbajaj

Hello @v-sabiraj please give a update on this

v-prasadboke avatar Apr 18 '23 13:04 v-prasadboke

Hello @v-sabiraj please provide your update on this

v-prasadboke avatar Apr 25 '23 11:04 v-prasadboke

Hello @v-sabiraj waiting for your feedback

v-prasadboke avatar Apr 27 '23 11:04 v-prasadboke

Hello @v-sabiraj please provide your update on this

v-atulyadav avatar May 03 '23 04:05 v-atulyadav

Hello @v-sabiraj please provide your feedback

v-prasadboke avatar May 05 '23 05:05 v-prasadboke

Hello @v-sabiraj waiting for your feedback

v-prasadboke avatar May 09 '23 12:05 v-prasadboke

Hi @sreedharande, please provide your feedback on this. Thanks

v-atulyadav avatar May 11 '23 09:05 v-atulyadav

Hi @sreedharande, please provide your feedback

v-prasadboke avatar May 18 '23 16:05 v-prasadboke

Hi @swiftsolves-msft , while this is valuable content, the transformation library is not the right place for it, as there are no transformations in your DCR. I would suggest a new folder under Tools for this.

javiersoriano avatar Jun 23 '23 06:06 javiersoriano

Hi @swiftsolves-msft, please act on @javiersoriano's comments. Thanks

v-atulyadav avatar Jun 27 '23 06:06 v-atulyadav

looks good to me

javiersoriano avatar Jul 07 '23 06:07 javiersoriano