Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

v-prasadboke/workbook

Open v-prasadboke opened this issue 3 years ago • 3 comments

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


v-prasadboke avatar Dec 26 '22 08:12 v-prasadboke

We will be using this PR for next week's weekly sync and see if it is working fine, till then please do not merge this PR... Thanks!!

v-rucdu avatar Dec 30 '22 05:12 v-rucdu

@v-prasadboke : Please resolve the conflicts. Thanks !

v-spadarthi avatar Jan 04 '23 04:01 v-spadarthi

Working on this.

v-sabiraj avatar Jan 11 '23 05:01 v-sabiraj

Will be resolving conflicts, thanks.

v-sabiraj avatar Jan 18 '23 05:01 v-sabiraj

Fixed conflicts

v-sabiraj avatar Jan 20 '23 06:01 v-sabiraj

Working on tool changes to fix this.

v-sabiraj avatar Jan 27 '23 06:01 v-sabiraj

Closing this PR.

v-sabiraj avatar May 12 '23 11:05 v-sabiraj