Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Updated analytical rule for anyalytical validation test

Open mkchiliveri opened this issue 3 years ago • 1 comments

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


mkchiliveri avatar Oct 14 '22 11:10 mkchiliveri

Hi @mkchiliveri Sorry for multiple comments. I just realized that there was an old PR #5138 related to AWS that was merged to the master recently, so all the files in the detections folder moved to AWS solution folder. Can you please make the respective changes in this folder instead of detection folder

v-mchatla avatar Oct 17 '22 10:10 v-mchatla

Hi @mkchiliveri, Please let me know if you need any clarity on the above request. Thanks

v-mchatla avatar Oct 18 '22 06:10 v-mchatla

Hi @mkchiliveri, Can you please accommodate the changes requested above. Let me know if you need any help over there. Thanks

v-mchatla avatar Oct 21 '22 04:10 v-mchatla

Hi @mkchiliveri, Can you please accommodate the changes requested above. Let me know if you need any help over there. Thanks

v-mchatla avatar Oct 25 '22 10:10 v-mchatla

Hi @mkchiliveri Can you please help us by accommodating the requested changes, let me know if you need any help over there. Thanks

v-mchatla avatar Oct 28 '22 05:10 v-mchatla

Hi @mkchiliveri, It would be great if you could provide any update on the above request. Thanks

v-mchatla avatar Nov 02 '22 03:11 v-mchatla

Hi @mkchiliveri, Can you please provide update on the requested changes Thanks

v-mchatla avatar Nov 04 '22 04:11 v-mchatla

Hi @mkchiliveri, Can you please address the suggested changes. Thanks

v-mchatla avatar Nov 08 '22 04:11 v-mchatla

Hi @mkchiliveri, Can you please resolve the conflicts. Thanks

v-mchatla avatar Nov 10 '22 11:11 v-mchatla

Hi @mkchiliveri, Can you please resolve conflicts. Thanks

v-mchatla avatar Nov 16 '22 04:11 v-mchatla

Hi @mkchiliveri, It would be great if you could spare sometime on fixing the conflicts. Thanks

v-mchatla avatar Nov 18 '22 05:11 v-mchatla

Hi @mkchiliveri We wanted to check on the status of PR #6393. PR is pending from more than 30 days. Let us know if any assistance is required for this PR. As per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation. Thanks

v-mchatla avatar Nov 23 '22 05:11 v-mchatla

Hi @mkchiliveri, I hope you are having a busy day. Please address the changes suggested, if you want to take it later move the PR to draft or close and reopen when you want to continue work on this. Thanks

v-mchatla avatar Nov 25 '22 05:11 v-mchatla

Hi @mkchiliveri,. Can you please address the changes. Thanks

v-mchatla avatar Nov 30 '22 04:11 v-mchatla

Hi @mkchiliveri, If you need some time to work on this, please move this PR to draft and resume once you get time. Thanks

v-mchatla avatar Dec 02 '22 05:12 v-mchatla

Hi @mkchiliveri Since we have not received response from last 7 days, we are closing your PR per our standard operating procedures. If you still need support for this issue you can re-open the PR at any time. If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

v-mchatla avatar Dec 07 '22 04:12 v-mchatla