Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Adding Mandiant Advantage Threat Intelligence Solution

Open chrishultin opened this issue 3 years ago • 9 comments

Required items, please complete

Change(s):

  • Initial commit for adding Mandiant Advantage Threat Intelligence solution

Reason for Change(s):

  • Adding Mandiant Advantage Threat Intelligence solution

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help

chrishultin avatar Sep 28 '22 16:09 chrishultin

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: chrishultin sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

ghost avatar Sep 28 '22 16:09 ghost

@chrishultin : While checking Logo we are getting below error please check and fix it. image Ensure raw file of logo does not have any of the following: 1.cls and style formats 2.embedded png formats 3.data-name

v-spadarthi avatar Sep 29 '22 09:09 v-spadarthi

@manishkumar1991 :Please review the playbooks and provide your feedback. Thanks!

v-spadarthi avatar Sep 29 '22 09:09 v-spadarthi

Logo is good validation passed image Once playbook reviewed and approved from @manishkumar1991 we can be good to merge. @chrishultin: Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 30 '22 06:09 v-spadarthi

Hi @manishkumar1991 Can you please review the playbooks and provide your feedback. thanks

v-mchatla avatar Oct 04 '22 19:10 v-mchatla

Hi @manishkumar1991 Can you please review the playbooks and provide your feedback. thanks

Hello I have reviewed the playbook , and my feedback is, currently we don't support multi dependency deployment, for key vault , storage account creation and many other within playbook template, So requesting PR submitter to replace the creation of key vault and storage account resources . with the use of existing one and mention the procedure in readme.md file which is missing in this PR , Can take help from link mentioned below :

https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ThreatXCloud/Playbooks/ThreatXPlaybooks/ThreatX-BlockIP-URL/azuredeploy.json

and instead of using the http call for mandiant api , recommend building one logic app custom connector.

and if this is going to be considered as separate solution, will it contain only one playbook?

@v-mchatla @v-spadarthi @chrishultin

manishkumar1991 avatar Oct 06 '22 13:10 manishkumar1991

@chrishultin, can you please check on feedback from Manish? Also please sign license/cla, thanks.

v-sabiraj avatar Oct 10 '22 12:10 v-sabiraj

@chrishultin, can you please check on feedback from Manish? Also please sign license/cla, thanks.

v-spadarthi avatar Oct 13 '22 14:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign license/cla, thanks.

v-spadarthi avatar Oct 17 '22 08:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign license/cla, thanks.

v-spadarthi avatar Oct 19 '22 05:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Oct 20 '22 08:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Oct 25 '22 07:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Oct 28 '22 05:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Oct 31 '22 06:10 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 02 '22 01:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 04 '22 01:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 08 '22 05:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 11 '22 04:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 14 '22 05:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 16 '22 04:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 17 '22 11:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 21 '22 06:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 23 '22 04:11 v-spadarthi

@chrishultin, can you please check on feedback from Manish? Also please sign in license/cla, thanks.

v-spadarthi avatar Nov 25 '22 03:11 v-spadarthi

@chrishultin : We wanted to check on the status of PR . PR is pending from more than 60 days. Let us know if any assistance is required for this PR. As Per our standard operating procedures if no response is received in the next 7 business days we will close this PR. Thank you for your cooperation.

v-spadarthi avatar Nov 28 '22 04:11 v-spadarthi

Apologies for the delay. I've been waiting for my company to approve my signing of the CLA before proceeding.

chrishultin avatar Nov 28 '22 04:11 chrishultin

@chrishultin : we are waiting for the update from author.

v-spadarthi avatar Nov 30 '22 04:11 v-spadarthi

@chrishultin : we are waiting for the update from author.

v-spadarthi avatar Dec 02 '22 04:12 v-spadarthi

@chrishultin : we are waiting for the update from author.

v-spadarthi avatar Dec 06 '22 06:12 v-spadarthi

@chrishultin : we are waiting for the update from author.

v-spadarthi avatar Dec 08 '22 11:12 v-spadarthi