Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Adding Content for SQL PaaS Solution

Open v-sabiraj opened this issue 3 years ago • 11 comments

Publisherid, offerid and solution id needs to be changed

v-sabiraj avatar Jul 20 '22 10:07 v-sabiraj

@v-rucdu :Please review.

v-spadarthi avatar Aug 08 '22 14:08 v-spadarthi

@v-sabiraj could you please check if we can merge this PR?

v-laanjana avatar Sep 08 '22 11:09 v-laanjana

@v-sabiraj : Please resolve the comments and conflicts as well.

v-spadarthi avatar Sep 15 '22 10:09 v-spadarthi

@v-sabiraj : Please resolve the comments and conflicts as well.

v-spadarthi avatar Sep 20 '22 08:09 v-spadarthi

@v-sabiraj : Please resolve the comments and conflicts as well.

v-spadarthi avatar Sep 22 '22 14:09 v-spadarthi

@v-sabiraj : Please resolve the comments and conflicts as well.

v-spadarthi avatar Sep 27 '22 05:09 v-spadarthi

@v-sabiraj : Please resolve the comments and conflicts as well.

v-spadarthi avatar Sep 30 '22 04:09 v-spadarthi

@v-sabiraj : Please resolve the comments and conflicts as well.

v-amolpatil avatar Oct 07 '22 04:10 v-amolpatil

Resolved conflicts, can you please approve and merge this as the content is already live in content hub and we are just adding it in GitHub, thanks.

v-sabiraj avatar Oct 09 '22 07:10 v-sabiraj

@v-sabiraj : As discussed, please have a look and provide an update. Thanks!

v-spadarthi avatar Oct 12 '22 05:10 v-spadarthi

@v-sabiraj : As discussed, please have a look and provide an update. Thanks!

v-spadarthi avatar Oct 14 '22 05:10 v-spadarthi

@v-sabiraj is working on fixing the comment given by Shain... Thanks!!

v-rucdu avatar Oct 19 '22 05:10 v-rucdu

Hi @shainw, actually these analytic rules and hunting queries are already live in content hub and we are just adding in GitHub. Can you please help us on fixing these queries as we are not able to test in our environment, thanks.

v-sabiraj avatar Oct 19 '22 12:10 v-sabiraj

Hi @shainw, actually these analytic rules and hunting queries are already live in content hub and we are just adding in GitHub. Can you please help us on fixing these queries as we are not able to test in our environment, thanks.

v-spadarthi avatar Oct 25 '22 09:10 v-spadarthi

@shainw, done this change, can you please approve, thanks.

v-sabiraj avatar Oct 26 '22 05:10 v-sabiraj

@shainw Can you please provide your approval? Thanks.

NikTripathi avatar Nov 02 '22 06:11 NikTripathi

@shainw Can you please provide your approval? Thanks.

v-sabiraj avatar Nov 04 '22 05:11 v-sabiraj

@shainw : Need your assistance here... please take a look... Thanks!!!

v-rucdu avatar Nov 09 '22 04:11 v-rucdu

@v-sabiraj : As discussed, please close the open comment from Shain and request him re-approval... Thanks!!

v-rucdu avatar Nov 16 '22 05:11 v-rucdu

Some fixes needed in the hunting queries. Additionally, in general, the Analytic Rules are duplicated with just some different parameters passed thru. It looks like you have 2 categories of queries using the same base query. Each category would be best to be combined into a single, custom details, this way only 1 query is need for each of these sets of queries - Detection-Errors* and Detection-Hotwords*

The items I commented on before still need to be fixed.

shainw avatar Nov 22 '22 02:11 shainw

Hi @shainw, I updated the queries, thanks.

v-sabiraj avatar Nov 25 '22 13:11 v-sabiraj