Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard
verified publisher icon Azure

Fix errors in the playbook ARM templates

Open sansanj opened this issue 3 years ago • 14 comments

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

sansanj avatar Jul 11 '22 17:07 sansanj

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: sansanj sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

ghost avatar Jul 11 '22 17:07 ghost

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-mchatla avatar Sep 05 '22 07:09 v-mchatla

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 08 '22 08:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 15 '22 09:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 20 '22 05:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 22 '22 13:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 27 '22 05:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution.

v-spadarthi avatar Sep 29 '22 10:09 v-spadarthi

Hi @sansanj Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-mchatla avatar Oct 04 '22 20:10 v-mchatla

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-amolpatil avatar Oct 07 '22 04:10 v-amolpatil

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 10 '22 07:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 12 '22 05:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 13 '22 14:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 17 '22 09:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 19 '22 05:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 20 '22 07:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 25 '22 07:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 27 '22 12:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Oct 31 '22 06:10 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Nov 02 '22 00:11 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Nov 04 '22 00:11 v-spadarthi

Hi @sansanj , Your changes are approved by the reviewers. Seems some issue with Contributor License Agreement acceptance, please try to sign Contributor License Agreement again to accept your contribution. Let us know if you need any help over there. Thanks

v-spadarthi avatar Nov 08 '22 03:11 v-spadarthi

We wanted to check on the status of PR #5593 . PR is pending from more than 60 days. Let us know if any assistance is required for this PR. As Per our standard operating procedures if no response is received in the next 7 business days we will close this PR. Thank you for your cooperation.

v-spadarthi avatar Nov 10 '22 11:11 v-spadarthi

We are waiting for the update from author.

v-spadarthi avatar Nov 14 '22 04:11 v-spadarthi

We are waiting for the update from author.

v-spadarthi avatar Nov 16 '22 04:11 v-spadarthi

We are waiting for the update from author.

v-spadarthi avatar Nov 17 '22 11:11 v-spadarthi

Hi @sansanj, since we have not received response from last 7 days, we are closing your PR per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time. If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

v-spadarthi avatar Nov 21 '22 06:11 v-spadarthi