Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Test

Open Kingwins007 opened this issue 1 year ago • 2 comments

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


Kingwins007 avatar Oct 24 '24 14:10 Kingwins007

Hello @Kingwins007, If this is a test PR could you please move it to Draft state

v-prasadboke avatar Oct 25 '24 05:10 v-prasadboke

Moving the PR to draft since this seems to be raised for testing purpose and no action from author from 2 weeks.

v-dvedak avatar Nov 06 '24 04:11 v-dvedak

We wanted to check on the status of PR #11326. PR is pending for more than 45+ days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation.

v-prasadboke avatar Jan 20 '25 11:01 v-prasadboke

Since we have not received a response in the last 7 days, we are closing your PR #11326 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.

If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

v-prasadboke avatar Jan 28 '25 13:01 v-prasadboke