Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard
verified publisher icon Azure

Formatting fixes revealed during parsing

Open ccmsft opened this issue 1 year ago • 4 comments

Required items, please complete

Change(s):

  • Updated metadata for rules to adhere to convention.

Reason for Change(s):

  • Some rule metadata was incorrect

ccmsft avatar Oct 18 '24 14:10 ccmsft

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

contentautomationbot[bot] avatar Oct 18 '24 14:10 contentautomationbot[bot]

Hello @ccmsft , Thanks for raising this PR. This PR will be investigated, and we will update you about the same before 23-10-2024. Thanks...!!

v-shukore avatar Oct 21 '24 12:10 v-shukore

Hi @ccmsft,

Please update the version of all Hunting Queries that you have modified, as the validation checks are failing due to the version not being updated. image

Thanks...!!

v-shukore avatar Oct 22 '24 06:10 v-shukore

Hi @ccmsft, please update on above comment. Thanks

v-shukore avatar Oct 24 '24 10:10 v-shukore

Hi @tduarte14, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

v-shukore avatar Oct 29 '24 04:10 v-shukore

Hi @ccmsft, please update on above comment. Thanks...!!

v-shukore avatar Nov 04 '24 08:11 v-shukore

Hi @tduarte14, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

v-shukore avatar Nov 14 '24 05:11 v-shukore

Hi @ccmsft,

We wanted to check on the status of PR #11300. PR is pending for more than 30 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR.

Thank you for your cooperation.

v-shukore avatar Nov 18 '24 04:11 v-shukore

Hi @ccmsft, please update the Hunting Queries version to resolve the validation checks. After that, we can proceed with the next steps. Thanks!

v-shukore avatar Nov 26 '24 08:11 v-shukore

Hi @ccmsft, please repackage the solutions using V3 tool and commit the changes. https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md Thanks!!

v-shukore avatar Dec 02 '24 05:12 v-shukore

Hi @ccmsft, waiting for your update please do the packaging to proceed. Thanks!!

v-shukore avatar Dec 06 '24 07:12 v-shukore

PR is too large, will potentially just provide a parsing tool to identify issues missed in current validations.

ccmsft avatar Dec 06 '24 13:12 ccmsft