AgentBaker icon indicating copy to clipboard operation
AgentBaker copied to clipboard

fix: build CVM image on CVM hardware

Open zachary-bailey opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind fix

What this PR does / why we need it:

This PR directs the build pipeline to build CVM images on dedicated CVM hardware. This allows apt updates for the CVM image during the build process. Original PR from @anujmaheshwari1 enabling this can be found here: fix: install upgrades for CVM images in pre-install dependencies. This PR also adds the changes originally made in that PR.

Which issue(s) this PR fixes:

CVM breaks on kernel image updates due to null-boot package post-install.

Notes:

NEVER MERGE label is assigned to this PR until necessary changes in ACG are made to support the new workflow it requires. These changes should be simple.

If merged, these changes would require the availability and quota of Confidential Compute VMs in the build region, which is why this adds a conditional region check in .pipelines/.vsts-vhd-builder-release.yaml for CVMs. This will prevent failing pipelines due to not having Confidential Compute cores available.

Requirements:

zachary-bailey avatar Sep 05 '24 15:09 zachary-bailey

Pull Request Test Coverage Report for Build 11111092251

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.271%

Totals Coverage Status
Change from base Build 11108979051: 0.0%
Covered Lines: 2590
Relevant Lines: 3634

💛 - Coveralls

coveralls avatar Sep 05 '24 15:09 coveralls

it sounds like we decided to set the staging gallery CVM definition to specialized right?

cameronmeissner avatar Sep 05 '24 20:09 cameronmeissner

it sounds like we decided to set the staging gallery CVM definition to specialized right?

Yes. Planning on doing this programmatically, I put the code necessary to do so in init-variables.sh. So the first run, it should look for the def and since its not there, create it. Then upload fine. Anuj asked to review that change before I run it the first time in the test pipeline so just waiting on that. @cameronmeissner

zachary-bailey avatar Sep 05 '24 20:09 zachary-bailey