modern-data-warehouse-dataops icon indicating copy to clipboard operation
modern-data-warehouse-dataops copied to clipboard
verified publisher icon Azure-Samples

Brsherwi/refacatordeploy

Open bsherwin opened this issue 9 months ago • 2 comments

Type of PR

  • Code changes

Purpose

This PR is a rewrite of the bash shell scripts for the e2e_samples/parking_sensors so that the scripts are more modular and easier to maintain. They were rewritten to be functions and not sequential scripts. When values are required, they are queried rather than necessarily passed in as environment values. This makes the scripts able to be restarted if there is a failure at some step in the deployment process.

Author pre-publish checklist

  • [X] No PII in logs

Validation steps

  • Run the deploy.sh script from the root folder.
  • If you choose, press ctrl+c to stop the script at any point and restart it.
  • Additionally, you could run individual scripts from the scripts folder.

bsherwin avatar May 12 '25 19:05 bsherwin

I had a quick look through.. looks great! I like how you wrapped things in functions so it's what the script is doing. Also, I also like the pattern of looking up what was deployed (similar to using the bicep existing).

devlace avatar May 13 '25 06:05 devlace

Walk through with @bsherwin and it all looks good to me.

image Attaching image of successful deploy

Matt Luker doesn't have write access to approve, but we walkthrough a pair code review. @jose-perales or @devlace can you give a write approval?

bsherwin avatar Jun 13 '25 19:06 bsherwin