modern-data-warehouse-dataops
modern-data-warehouse-dataops copied to clipboard
[BUG] post_create script should ensure all sh files are executable
Description
- When a new
shfile is added to the sample, you will need to remember to do achmod +x scriptsto ensure all scripts are executable
Expected Behavior
- Deployment does not fail because scripts cannot be executed
Reproduce
- Create a new
shfile - try to execute it
- you will get a
bash: line 1: /path/to/script.sh: Permission denied
Additionally, all .sh scripts should also reflect LF line endings when attempting to run in bash. Windows (including WSL) is not always set correctly and CRLF causes failures when trying to run the scripts in bash. We should consider including a .gitattributes file to ensure that .sh files have LF only line endings.
Sample .gitattributes file:
*.sh text eol=lf
Will include guidance to contributing.md