Azure-Player
Create empty blob if not exist.
@NowinskiK sorry for the quick pull request. Found a bug in the incremental deployment. Sorry for the inconvenience.
@LiquoriChris, can you make sure first you have the latest version of the code from main branch?
Also, before (or now after) fixing the bug, could you cover the case with an appropriate unit test?
Hey @NowinskiK, can you please re-check the code? I have updated when you mentioned in your first comment. Please let me know if I have missed anything.
Hey @NowinskiK, can you please re-check the code? I have updated when you mentioned in your first comment. Please let me know if I have missed anything.
Hey @NowinskiK, sorry to bother. Can you please see comment above?
Apologies. I removed the quotes in the original pr, but added them back in. Sorry about that.
That's all right, but that was one of the reasons why it was with you. There is another comment above - please scroll and check. Optionally you can check "Files changed" section (tab).
I do not think I can see comments in the files changed. It does not show any comments in the files changed tab.
ah... thanks! I should click "Request changes" then all my comments are moved here (see above).
Hello @NowinskiK I have cleaned up the code (Thanks for that suggestion). I also updated the tests to make sure they pass.
Hello @NowinskiK,
I know it has been a while. Can you please see if this is still ok? I've updated the code per comments.
But... there are still TRY/CATCH blocks. Example: DeploymentState.class.ps1 file. Why is that? You can check this code for reference: https://github.com/Azure-Player/azure.datafactory.tools/blob/master/private/DeploymentState.class.ps1 It's ADFTools with incremental deployment with storage implemented.
I added try/catch just in case of failure... But I can remove entirely.
My point is that it does nothing. You catch potential error and rethrow it. I can't see the logic.