azurapi-js icon indicating copy to clipboard operation
azurapi-js copied to clipboard

Add `.internal` file handling from the setup repo

Open Mevas opened this issue 3 years ago • 3 comments

Refactored the way data urls are obtained and added node-fetch to have access to the status of the request, so that the .internal version of a data file is tried in the case of the initial request returning a 404.

The PR is marked as draft as there seem to be some differences in the format of internal files compared to what normal files looked like, I assume, leading to the majority of the tests breaking, such as there being no "IJN" nationality, instead expecting "Sakura Empire". The data format is outside the scope of my knowledge, so someone else should most likely fix these compatibility issues.

Mevas avatar Aug 31 '22 02:08 Mevas

would recommend yea to split the node fetch to a separate pull request :)

jasperchua99 avatar Sep 07 '22 13:09 jasperchua99

The .internal files are marked for further transforming IIRC. I'm not sure if we should use them because that is not a fully transformed file. Probably needs additional discussion with @octo-kumo, who is the maintainer of the setup repo.

0t4u avatar Oct 28 '22 16:10 0t4u

Either that or they are just marked as internal because it is "unstable". I have no clue tbh.

0t4u avatar Oct 28 '22 16:10 0t4u