barretenberg icon indicating copy to clipboard operation
barretenberg copied to clipboard
verified publisher icon AztecProtocol

`*RecursiveVerifier.verify_proof` should receive `StdlibProof` rather than `HonkProof` as argument

Open maramihali opened this issue 1 year ago • 2 comments

We are currently constructing a StdlibProof from a HonkProof inside the recursive verifiers which is an insecure pattern. Moreover, not hashing the verification key leads to potential weak Fiat-Shamir issues.

maramihali avatar May 21 '24 11:05 maramihali

  • GoblinProof passed to the recursive verifier should also be a stdlib proof and translation evaluations should be constrained prior entering the verify function

maramihali avatar May 31 '24 09:05 maramihali

Please do not forget the AVM recursive verifier while working on this issue.

jeanmon avatar Aug 29 '24 16:08 jeanmon