AvdLee
Add basic watchOS support to better support multi platform apps
This PR is mainly to prevent compile time errors and doesn’t implement a good UX on watchOS. I have a multiplatform app. With Xcode 15 I can't build my app anymore as Roadmap fails to compile for watchOS. I think in most cases a Roadmap doesn't make sense on watchOS. But I'm not aware of a good way to restrict platforms for a Swift package.
https://forums.swift.org/t/restrict-platforms-for-packages/29456/7
Not mentioning watchOS in platforms just means the oldest watchOS version is supported implicitly.
I'm not 100% sure yet why Xcode even tries to compile Roadmap for watchOS in my project. I only have it as a dependency in my own Package.swift for a library target that is only added to an iOS target. I also added a TargetDependencyCondition .product(name: "Roadmap", package: "Roadmap", condition: .when(platforms: [.iOS])), And the actual view is surrounded with #if os(iOS) #endif But this iOS target also embeds my watchOS target.
This PR only fixes the errors. I didn't make any other changes so the watchOS UX is probably not very good. I don't plan to use Roadmap on my watchOS app anyway. But this is how the preview looks.
Edit: I missed another dependency that was also depending on Roadmap. Adding condition: .when(platforms: [.iOS])) there as well fixed things. So now it's not building for watchOS anymore. Therefore I don't need these changes anymore. But maybe it's still useful for others to have this basic compatibility. Then you don't need to constrain everything.
Hi @KaiOelfke, I'm not sure I understand the problem. You can exclude Roadmap from the watchOS target, and it compiles fine?
I'm using Roadmap on 4 different apps; all have a watchOS target, and I've never faced a problem.
Hi @KaiOelfke, I'm not sure I understand the problem. You can exclude Roadmap from the watchOS target, and it compiles fine?
I'm using Roadmap on 4 different apps; all have a watchOS target, and I've never faced a problem.
It sounds like you added Roadmap directly to frameworks, libraries and embedded content in Xcode for the iOS target, but not watchOS. And yes this should work. But my setup is different.
I only have a MySwiftPackageFramework target in the watchOS app target. In this MySwiftPackageFramework I had two dependencies that depend on Roadmap. In one of them I excluded watchOS via:
// Before, not working
.product(name: "Roadmap", package: "Roadmap")
// Now, (compiles fine}
.product(name: "Roadmap", package: "Roadmap", condition: .when(platforms: [.iOS]))
In the other one I forgot this. Which caused the compiler issues. After making the PR I found out that I missed the exclude in the second dependency and wrote the edit in my PR comment above. So as I said above I don't need the changes of this PR anymore. And I decided to leave it up to the community, if people want a basic watchOS compatibility or not. With this PR people can integrate Roadmap easier without having to understand how to properly exclude Roadmap.
For example if someone only has
#if os(iOS)
import Roadmap
RoadmapView()
#endif
This isn't enough. They either need to exclude it in the watchOS app target or in the Swift Package dependency depending on their setup.