CoreEx icon indicating copy to clipboard operation
CoreEx copied to clipboard

CoreEx versioning suggestion

Open karpikpl opened this issue 3 years ago • 2 comments

Hi, I think this package could benefit from https://github.com/dotnet/Nerdbank.GitVersioning tool

Just for your consideration. I could add that in to the pipeline.

karpikpl avatar Jan 26 '23 01:01 karpikpl

Hey @karpikpl, I would be interested in learning more given the following...

At the moment the version is specified (manually) within the common.targets as an explicitly updated version. Then the CHANGELOG is updated and changes logged against that version. One or more commits, and/or branches/pull requests, may then result in the output of a specific (single) published version contain all changes. Would definitely not want every interim merged version published to NuGet.

Then finally there is the manual step, currently outside of GitHub, to publish using the nuget-publish.ps1 when finally ready (this step is planned to be managed via GitHub with secret API key for publish - at some point).

Cheers...

chullybun avatar Jan 27 '23 19:01 chullybun

from what I can tell, this library provides few things:

  • adds git commit info to assemblies and build information
  • adds git id to preview versions
  • helps creating preview versions
  • version info is kept in version.json - either for entire solution or per project
  • automates branch creation for releases

other than that, nuget publish is still up to pipeline/developer.

I just found it interesting (also the fact that it's under github.com/dotnet)

feel free to close :) maybe we can revisit when pipeline work will happen

karpikpl avatar Jan 27 '23 20:01 karpikpl