wp-e2e-tests icon indicating copy to clipboard operation
wp-e2e-tests copied to clipboard

Canary tests fail on wpcalypso.wordpress.com but pass on production

Open alisterscott opened this issue 8 years ago • 18 comments

This is to keep track of the canary test failures running against wpcalypso.wordpress.com even though they are passing on production

cc: @hoverduck

alisterscott avatar Mar 17 '17 04:03 alisterscott

Could it be that wpcalypso.wordpress.com is a slower environment?

alisterscott avatar Mar 17 '17 04:03 alisterscott

Another possibility is back-to-back wpcalypso deploys cause existing running tests to fail

alisterscott avatar Mar 17 '17 06:03 alisterscott

Could it be that wpcalypso.wordpress.com is a slower environment?

This is true, so I tried bumping up the explicitWaitMS from 20 to 60s, but that didn't seem to make a difference (I've since returned it to the default).

What I'm seeing now that we have screenshots to Slack enabled (also via VNC) is that frequently in the signup process we're getting dumped on the login screen instead of the checkout page. The redirect in the URL is pointing back to checkout.

We're not seeing it on production, so I'm not sure yet what the problem is. The investigation continues.

hoverduck avatar Mar 17 '17 15:03 hoverduck

I wasn't able to reproduce this problem locally, either manually or with the scripts. Most of my time was spent futzing with CircleCI VNC problems, and had to keep restarting the session.

The only error I was able to track down was one time I saw a post-message failure from a wordpress.com iframe to wpcalypso, which I'm guessing may have had something to do with the oauth token. Then once that's gone screwy it thinks we're not logged in, and dumps us back on the login page instead of checkout.

But like I said, I wasn't able to reproduce it locally to confirm any of that. I'll dig in again and ping the Calypso folks on Monday, but we could also add a workaround to the signup flow to detect the login page and just re-authenticate. If it happens in production that's what the end user would do anyway.

hoverduck avatar Mar 17 '17 21:03 hoverduck

I've added a workaround in https://github.com/Automattic/wp-e2e-tests/pull/444, and asked the Calypso devs on p4TIVU-6cx-p2

I'm going to leave this issue open and re-label it as workaround

hoverduck avatar Mar 20 '17 17:03 hoverduck

This bug is rearing its head more frequently, and the workaround from #444 isn't working consistently anymore. I assume it's due to the work on the new login screen, but this screenshot (pulled from the Slack alert) looks like the wp-login.php page, not the new /log-in.

image

hoverduck avatar Jul 06 '17 19:07 hoverduck

Extra debug - https://github.com/Automattic/wp-e2e-tests/pull/613

hoverduck avatar Jul 06 '17 20:07 hoverduck

Updated workaround in #614

hoverduck avatar Jul 07 '17 15:07 hoverduck

Swapped out the paid sign up tests for free sign up test (temporarily) as this issue is causing us to lose confidence in the canaries. See #649

alisterscott avatar Aug 01 '17 00:08 alisterscott

Is there another environment we could use besides wpcalypso? Horizon? Or will that give us much the same results?

alisterscott avatar Aug 01 '17 00:08 alisterscott

Is there another environment we could use besides wpcalypso? Horizon? Or will that give us much the same results?

We could try Horizon to see if it suffers the same problem...it should have the same Calypso baseline as wpcalypso, barring any feature flag differences.

hoverduck avatar Aug 07 '17 14:08 hoverduck

Since the refresh bug (https://github.com/Automattic/wp-calypso/pull/16784) was fixed I am reenabling the paid sign up tests to see if we're still having issues with wpcalypso

See: https://github.com/Automattic/wp-e2e-tests/pull/653

alisterscott avatar Aug 08 '17 01:08 alisterscott

Updated in https://github.com/Automattic/wp-e2e-tests/pull/740 and all fine so closing this issue now

alisterscott avatar Oct 25 '17 04:10 alisterscott

This is still a problem

alisterscott avatar Dec 04 '17 01:12 alisterscott

Seeing this for free signups now :/

https://circleci.com/gh/Automattic/wp-e2e-tests-canary/9447#artifacts/containers/0

alisterscott avatar Aug 29 '18 04:08 alisterscott

Would it be worth turning on the video recordings for the canaries to get more detail about what's happening, or is that too much overhead for these tests?

hoverduck avatar Aug 29 '18 13:08 hoverduck

@hoverduck I've got it recording a PR here now and reproduced it in video: https://circleci.com/gh/Automattic/wp-e2e-tests/22412#artifacts/containers/0

I'm still trying to work out why

alisterscott avatar Aug 30 '18 05:08 alisterscott

The workaround in #1444 seems to be working well

alisterscott avatar Sep 07 '18 00:09 alisterscott