vip-cli icon indicating copy to clipboard operation
vip-cli copied to clipboard

fix(phpmyadmin): Add step to wait for PhpMyAdmin readiness.

Open aswasif007 opened this issue 1 year ago • 3 comments

Description

After spinning up the necessary pod to run PhpMyAdmin, we have to wait for the LB to be propagated, so that the requests to the PhpMyAdmin link are served the by PhpMyAdmin pod. In this PR, we are adding a step to wait to see the LB routing is happening before we generate an access.

Pull request checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build
  3. Run node ./dist/bin/vip db phpmyadmin @<app>.<env>. This should be run on an environment for which PMA is not enabled yet.
  4. Ensure that a browser page opened, and it did not end up with an error.

aswasif007 avatar May 02 '24 05:05 aswasif007

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

github-actions[bot] avatar May 02 '24 05:05 github-actions[bot]

Update: upon an offline discussion with Sarosh, we agreed to create a status/healthcheck endpoint in the phpMyAdmin itself, which will allow us to detect readiness in a cleaner way.

aswasif007 avatar May 03 '24 16:05 aswasif007

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar May 24 '24 06:05 sonarqubecloud[bot]