vip-cli
vip-cli copied to clipboard
fix(phpmyadmin): Add step to wait for PhpMyAdmin readiness.
Description
After spinning up the necessary pod to run PhpMyAdmin, we have to wait for the LB to be propagated, so that the requests to the PhpMyAdmin link are served the by PhpMyAdmin pod. In this PR, we are adding a step to wait to see the LB routing is happening before we generate an access.
Pull request checklist
- [ ] Update SETUP.md with any new environmental variables.
- [ ] Update the documentation.
- [ ] Manually test the relevant changes.
- [ ] Follow the pull request checklist
- [ ] Add/update automated tests as needed.
Steps to Test
- Check out PR.
- Run
npm run build - Run
node ./dist/bin/vip db phpmyadmin @<app>.<env>. This should be run on an environment for which PMA is not enabled yet. - Ensure that a browser page opened, and it did not end up with an error.
Dependency Review
✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
| Package | Version | Score | Details |
|---|
Scanned Manifest Files
Update: upon an offline discussion with Sarosh, we agreed to create a status/healthcheck endpoint in the phpMyAdmin itself, which will allow us to detect readiness in a cleaner way.
