Required parameters defined after optional ones

[GaryJones]

The code at https://github.com/Automattic/syndication/blob/b47a461679b6c8da8de93c18180aeedc3d4b2c6e/includes/class-syndication-logger.php#L251 has required parameters defined after optional ones (which means that they aren't actually optional), which is an issue with PHP 8.

Since this is a private method, then we are free to adjust the order. There only seems to be one call to it anyway.

I would also say that having each log entry include where it is stored, is not ideal. The single call to log() only defines object as the storage type anyway, and of that, only post has defined behaviour anyway.

If this logger is going to be refactored, then I would strongly recommend that the patterns of PSR-3 is followed - log level, the message, and then an array of contextual information.